Skip to content

CI: use OIDC #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

CI: use OIDC #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/components-integration-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
jobs:
components-launch:
runs-on: ubuntu-18.04
permissions:
id-token: write
contents: read
steps:
- name: Setup Python
uses: actions/setup-python@v2
Expand All @@ -17,19 +20,19 @@ jobs:
architecture: x64
- name: Checkout TorchX
uses: actions/checkout@v2
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@master
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
role-session-name: component-integration-tests
- name: Configure Kube Config
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
set -eux
if [ -n "$AWS_ACCESS_KEY_ID" ]; then
aws eks update-kubeconfig --region=us-west-2 --name=${{ secrets.EKS_CLUSTER_NAME }}
fi
- name: Configure Docker
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
set -eux
if [ -n "$AWS_ACCESS_KEY_ID" ]; then
Expand All @@ -42,8 +45,6 @@ jobs:
pip install -e .[kubernetes]
- name: Run Components Integration Tests
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
INTEGRATION_TEST_STORAGE: ${{ secrets.INTEGRATION_TEST_STORAGE }}
CONTAINER_REPO: ${{ secrets.CONTAINER_REPO }}
run: scripts/component_integration_tests.py
17 changes: 9 additions & 8 deletions .github/workflows/kfp-integration-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
jobs:
kfp-launch:
runs-on: ubuntu-18.04
permissions:
id-token: write
contents: read
steps:
- name: Install kubectl
# More info: https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/
Expand All @@ -18,10 +21,13 @@ jobs:
mkdir -p ~/.local/bin/kubectl
mv ./kubectl ~/.local/bin/kubectl
export PATH=$PATH:~/.local/bin/kubectl
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@master
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
role-session-name: kfp-integration-tests
- name: Configure Kube Config
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
set -eux
if [ -n "$AWS_ACCESS_KEY_ID" ]; then
Expand All @@ -35,9 +41,6 @@ jobs:
- name: Checkout TorchX
uses: actions/checkout@v2
- name: Configure Docker
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
set -eux
if [ -n "$AWS_ACCESS_KEY_ID" ]; then
Expand All @@ -50,8 +53,6 @@ jobs:
python setup.py install
- name: Run KFP Integration Tests
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
KFP_NAMESPACE: ${{ secrets.KFP_NAMESPACE }}
INTEGRATION_TEST_STORAGE: ${{ secrets.INTEGRATION_TEST_STORAGE }}
CONTAINER_REPO: ${{ secrets.CONTAINER_REPO }}
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/kubernetes-dist-train-integration-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
jobs:
kubernetes-launch:
runs-on: ubuntu-18.04
permissions:
id-token: write
contents: read
steps:
- name: Setup Python
uses: actions/setup-python@v2
Expand All @@ -17,22 +20,22 @@ jobs:
architecture: x64
- name: Checkout TorchX
uses: actions/checkout@v2
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@master
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
role-session-name: kubernetes-dist-train-integration-tests
- name: Configure Kube Config
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
set -eux
if [ -n "$AWS_ACCESS_KEY_ID" ]; then
if [ -n "$AWS_ROLE_ARN" ]; then
aws eks update-kubeconfig --region=us-west-2 --name=${{ secrets.EKS_CLUSTER_NAME }}
fi
- name: Configure Docker
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
set -eux
if [ -n "$AWS_ACCESS_KEY_ID" ]; then
if [ -n "$AWS_ROLE_ARN" ]; then
aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin 495572122715.dkr.ecr.us-west-2.amazonaws.com
fi
- name: Install dependencies
Expand All @@ -41,12 +44,10 @@ jobs:
pip install -e .[kubernetes]
- name: Run Kubernetes Integration Tests
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
INTEGRATION_TEST_STORAGE: ${{ secrets.INTEGRATION_TEST_STORAGE }}
CONTAINER_REPO: ${{ secrets.CONTAINER_REPO }}
run: |
if [ -z "$AWS_ACCESS_KEY_ID" ]; then
if [ -z "$AWS_ROLE_ARN" ]; then
# only dryrun if no secrets
ARGS="--dryrun"
else
Expand Down