CI: use OIDC #256
Closed
CI: use OIDC #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
oidc
branch
2 times, most recently
from
5e9819d to
a408283
Compare
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 91.56% 91.60% +0.04%
==========================================
Files 60 60
Lines 2762 2764 +2
==========================================
+ Hits 2529 2532 +3
+ Misses 233 232 -1
Continue to review full report at Codecov.
|
d4l3k
force-pushed
the
oidc
branch
10 times, most recently
from
191bb98 to
014714a
Compare
|
@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
|
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our integration tests to use the GitHub OpenID Connect credentials provider instead of using hard coded AWS session tokens. This will issue tokens that last for 1 hour so should be a lot more secure (and trackable) than before.
https://awsteele.com/blog/2021/09/15/aws-federation-comes-to-github-actions.html
Test plan:
CI
created PR from external repo to verify they can't generate tokens #257