CI: use OIDC (pr) #257
Closed
CI: use OIDC (pr) #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
Summary: This switches our integration tests to use the GitHub OpenID Connect credentials provider instead of using hard coded AWS session tokens. This will issue tokens that last for 1 hour so should be a lot more secure (and trackable) than before. https://awsteele.com/blog/2021/09/15/aws-federation-comes-to-github-actions.html Pull Request resolved: #256 Test Plan: CI created PR from external repo to verify they can't generate tokens #257 Reviewed By: kiukchung Differential Revision: D31674489 Pulled By: d4l3k fbshipit-source-id: 5936c64794816eb9fafe76899af44e2f865c64df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: