Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by fields "lost" on filtered aggregated question #11561

Closed
flamber opened this issue Dec 19, 2019 · 0 comments · Fixed by #11751
Closed

Group by fields "lost" on filtered aggregated question #11561

flamber opened this issue Dec 19, 2019 · 0 comments · Fixed by #11751
Assignees
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@flamber
Copy link
Contributor

flamber commented Dec 19, 2019

Describe the bug
After creating a question with a filter on aggregated data, and saving the question, the group-by are "lost"/empty (just displays an arrow ), but the question still works. Though it's not possible to change/remove the group-by.

Logs
When trying to remove the group-by (via the X under Editor), it gives this error:

Firefox: TypeError: e.field(...).name is undefined
Chromium: Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined

To Reproduce

  1. Custom question > Sample Dataset > Orders
  2. Summarize Count by User->ID
  3. Filter Count > 5
  4. Visualize and Save and refresh browser
  5. Check Editor where group-by shows a and cannot click any of Xs to remove it or the entire Summarize section.
  6. Notice the empty Group By in Simple > Summarize.

Screenshots
image
image

Information about your Metabase Installation:
Metabase 0.33.6/0.33.7.3 (didn't test on master because of #11560) on various backends/browsers.

Additional context
https://discourse.metabase.com/t/cannot-remove-a-seemingly-corrupted-group-by-field/8387
Related to #11495 - perhaps a duplicate, but I was getting different errors.
And perhaps a side-issue of #11235, which confused me in thinking it was not fixed

@flamber flamber added .Needs Triage Type:Bug Product defects labels Dec 19, 2019
@mazameli mazameli added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook Items specific to the Custom/Notebook query builder and removed .Needs Triage labels Dec 19, 2019
@tlrobinson tlrobinson self-assigned this Jan 13, 2020
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Aug 22, 2022
nemanjaglumac added a commit that referenced this issue Aug 22, 2022
* Delete unused scenarios from 12568

* Refactor repro for 12568

* Refactor repro 12507

* Refactor repro 10474

* Refactor repro 14787

* Refactor repro 14724

* Refactor repro 15352

* Refactor repro 15808

* Refactor repro 15397

* Merge repros 15808, 16938, 18364

* Move repro for #11561 over to nested questions spec
nemanjaglumac added a commit that referenced this issue Aug 22, 2022
* Delete unused scenarios from 12568

* Refactor repro for 12568

* Refactor repro 12507

* Refactor repro 10474

* Refactor repro 14787

* Refactor repro 14724

* Refactor repro 15352

* Refactor repro 15808

* Refactor repro 15397

* Merge repros 15808, 16938, 18364

* Move repro for #11561 over to nested questions spec
nemanjaglumac added a commit that referenced this issue Aug 22, 2022
* Delete unused scenarios from 12568

* Refactor repro for 12568

* Refactor repro 12507

* Refactor repro 10474

* Refactor repro 14787

* Refactor repro 14724

* Refactor repro 15352

* Refactor repro 15808

* Refactor repro 15397

* Merge repros 15808, 16938, 18364

* Move repro for #11561 over to nested questions spec
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants