Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting a question to SQL/Native keeps the /notebook in the URL #12651

Closed
flamber opened this issue Jun 5, 2020 · 0 comments · Fixed by #17873
Closed

Converting a question to SQL/Native keeps the /notebook in the URL #12651

flamber opened this issue Jun 5, 2020 · 0 comments · Fixed by #17873
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Native The SQL/native query editor Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:UX
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Jun 5, 2020

Describe the bug
When converting a question to SQL/Native, then the URL keeps the /notebook in the URL.

To Reproduce

  1. Simple question > Sample Dataset > Orders
  2. Click Editor-icon in top-right corner (notice /notebook is added to the URL, which is correct)
  3. Click "View the SQL" and "Convert this question to SQL" (the /notebook is kept, incorrect)
  4. Save question and do a browser refresh, which then does not auto-run the query, since the URL still contains /notebook - manually removing that from the URL makes it work as normal.

Expected behavior
Remove the /notebook when going from Notebook to SQL/Native editor.

Information about your Metabase Installation:
Metabase 0.33.0 thru 0.35.4

Additional context
This is not information stored with the question, just a state which causes a strange behavior on browser refresh - and in case people copy+paste the URL to other people.

@flamber flamber added Type:UX Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Native The SQL/native query editor .Frontend Querying/Notebook Items specific to the Custom/Notebook query builder labels Jun 5, 2020
@Opalevanescence Opalevanescence added this to Unfixed Issues (but cypress repro has been made) in Cypress Testing Jul 16, 2020
paulrosenzweig pushed a commit that referenced this issue Jul 20, 2020
* Add repro for #12651

* Refactor test

- stick to CSS classes when targetting icons

* Skip the test

- skip the test until the issue is resolved
- added reference to the original issue in the test description
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 1, 2020
@pawit-metabase pawit-metabase self-assigned this Sep 14, 2021
@rlotun rlotun added this to the 0.41 milestone Sep 15, 2021
@deploysentinel deploysentinel bot mentioned this issue Jul 7, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Native The SQL/native query editor Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants