-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting a question to SQL/Native keeps the /notebook
in the URL
#12651
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Native
The SQL/native query editor
Querying/Notebook
Items specific to the Custom/Notebook query builder
.Reproduced
Issues reproduced in test (usually Cypress)
Type:UX
Milestone
Comments
flamber
added
Type:UX
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Native
The SQL/native query editor
.Frontend
Querying/Notebook
Items specific to the Custom/Notebook query builder
labels
Jun 5, 2020
This was referenced Jul 12, 2020
Merged
Opalevanescence
added this to Unfixed Issues (but cypress repro has been made)
in Cypress Testing
Jul 16, 2020
paulrosenzweig
pushed a commit
that referenced
this issue
Jul 20, 2020
This was referenced Jan 11, 2024
Merged
This was referenced Apr 30, 2024
Merged
Closed
This was referenced May 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Native
The SQL/native query editor
Querying/Notebook
Items specific to the Custom/Notebook query builder
.Reproduced
Issues reproduced in test (usually Cypress)
Type:UX
Describe the bug
When converting a question to SQL/Native, then the URL keeps the
/notebook
in the URL.To Reproduce
/notebook
is added to the URL, which is correct)/notebook
is kept, incorrect)/notebook
- manually removing that from the URL makes it work as normal.Expected behavior
Remove the
/notebook
when going from Notebook to SQL/Native editor.Information about your Metabase Installation:
Metabase 0.33.0 thru 0.35.4
Additional context
This is not information stored with the question, just a state which causes a strange behavior on browser refresh - and in case people copy+paste the URL to other people.
The text was updated successfully, but these errors were encountered: