Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit > Questions > Total runtime displays link instead of an actual time #18317

Closed
nemanjaglumac opened this issue Oct 7, 2021 · 1 comment
Assignees
Labels
Administration/Metabase analytics Pro and Enterprise meta analytics, fka audit Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
Total runtime column in Audit > Questions > All questions table displays link instead of an actual running time for that question. The link points to root(localhost:3000)/running_time

Logs
Console is riddled with (literary over a thousand errors) column is missing field_ref so I can't see anything else, but there are most likely no visible errors for this.

To Reproduce
Steps to reproduce the behavior:

  1. Go to /admin/audit/questions/all
  2. Notice that all rows in "Total runtime" column display "Link"
  3. Hover the link and you'll see that it points to root/total_runtime

Expected behavior
Rows should display actual runtime.

Screenshots
image

Information about your Metabase Installation:
local dev, master, 2829168, H2, Sample dataset

Severity
P2?

Additional context
Regression since 1.40.5

@nemanjaglumac nemanjaglumac added Type:Bug Product defects Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Administration/Metabase analytics Pro and Enterprise meta analytics, fka audit labels Oct 7, 2021
@howonlee howonlee self-assigned this Oct 11, 2021
nemanjaglumac added a commit that referenced this issue Oct 17, 2021
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 17, 2021
github-actions bot pushed a commit that referenced this issue Oct 17, 2021
@rlotun rlotun added this to the 0.41.1 milestone Oct 20, 2021
@rlotun
Copy link
Contributor

rlotun commented Oct 20, 2021

Fixed by: #18432

@rlotun rlotun closed this as completed Oct 20, 2021
nemanjaglumac added a commit that referenced this issue Oct 21, 2021
nemanjaglumac added a commit that referenced this issue Oct 21, 2021
github-actions bot pushed a commit that referenced this issue Oct 21, 2021
nemanjaglumac added a commit that referenced this issue Oct 21, 2021
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Metabase analytics Pro and Enterprise meta analytics, fka audit Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

3 participants