Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ugly error state in Admin > Databases #20471

Closed
camsaul opened this issue Feb 11, 2022 · 3 comments · Fixed by #21607
Closed

Ugly error state in Admin > Databases #20471

camsaul opened this issue Feb 11, 2022 · 3 comments · Fixed by #21607
Assignees
@WiNloSt
Labels
Administration/Databases .Frontend .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.43

Comments

@camsaul
Copy link
Member

camsaul commented Feb 11, 2022

image

When the GET /api/databases endpoint returns an error you get a page that makes your eyes bleed.

  1. Tweak the endpoint so it fails e.g. Permissions paths validation is GET API endpoints is too strict; causes numerous endpoints to 500 if unknown entry is present #20470
  2. Admin > Databases
  3. Eyes bleeding

See also #20469
@flamber flamber added .Regression/master Regression that is only present on master, or bug in new upcoming feature and removed .Needs Triage labels Feb 13, 2022
@alxnddr alxnddr self-assigned this Feb 16, 2022
@alxnddr alxnddr mentioned this issue Feb 16, 2022
Closed
18 tasks
@nemanjaglumac
Copy link
Member

I tried to add some nonexistent and nonsensical key-value pair to the response.body.data[0], but the frontend didn't fail. Do I have to change some of the existing keys?

nemanjaglumac added a commit that referenced this issue Feb 22, 2022
@nemanjaglumac
Add repro for #20471
64d4714
@nemanjaglumac nemanjaglumac mentioned this issue Feb 22, 2022
Merged
nemanjaglumac added a commit that referenced this issue Feb 22, 2022
@nemanjaglumac
Repro #20471: Ugly error state in Admin > Databases (#20676)
f214d90 
* Add repro for #20471

* Remove deprecated `cy.server()`
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Feb 22, 2022
@ariya ariya assigned WiNloSt and unassigned alxnddr Mar 22, 2022
@WiNloSt
Copy link
Member

WiNloSt commented Mar 29, 2022

@flamber do you think doing something similar to #20824 would be ok i.e. Wrap those errors into a collapsible UI component.

@flamber
Copy link
Contributor

flamber commented Mar 29, 2022

@WiNloSt Yes, that would probably be good to show a nice error with the option to expand the actually returned error message.

@WiNloSt WiNloSt mentioned this issue Apr 12, 2022
Merged
WiNloSt added a commit that referenced this issue Apr 12, 2022
@WiNloSt
Fix repro for #20471 after #20953 is merged
00f3b25
@flamber flamber removed the .Regression/master Regression that is only present on master, or bug in new upcoming feature label Apr 22, 2022
WiNloSt added a commit that referenced this issue Apr 26, 2022
@WiNloSt
Fix repro for #20471 after #20953 is merged
7f69758
WiNloSt added a commit that referenced this issue Apr 29, 2022
@WiNloSt
Fix unfriendly admin databases error message (#21607)
41ad6c4 
* Fix repro for #20471 after #20953 is merged

* Make database list error message prettier
github-actions bot pushed a commit that referenced this issue Apr 29, 2022
@WiNloSt
Fix unfriendly admin databases error message (#21607)
68839db 
* Fix repro for #20471 after #20953 is merged

* Make database list error message prettier
nemanjaglumac pushed a commit that referenced this issue Apr 29, 2022
@github-actions @WiNloSt
Fix unfriendly admin databases error message (#21607) (#22258)
5fb8708 
* Fix repro for #20471 after #20953 is merged

* Make database list error message prettier

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
@flamber flamber added this to the 0.43 milestone Apr 30, 2022
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WiNloSt WiNloSt

Labels
Administration/Databases .Frontend .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

Fix unfriendly admin databases error message metabase/metabase
5 participants
@flamber @camsaul @WiNloSt @alxnddr @nemanjaglumac