Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL snippets show scrollbars when it isn't needed #21550

Closed
paoliniluis opened this issue Apr 8, 2022 · 0 comments · Fixed by #21725
Closed

SQL snippets show scrollbars when it isn't needed #21550

paoliniluis opened this issue Apr 8, 2022 · 0 comments · Fixed by #21725
Assignees
@ariya
Labels
.CSS Difficulty:Easy .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.43

Comments

@paoliniluis
Copy link
Contributor

Describe the bug
We show scrollbars for the SQL snippets even when it's not needed

Logs
None

To Reproduce
In a Metabase instance go to:

  1. new->sql query
  2. click on the snippets button
  3. Add a snippet as small as "select * from people* and save it
  4. now expand the snippet to see the scrollbars

Expected behavior
If we don't need scrollbars, either horizontal or vertical, we shouldn't show them

Screenshots
image

Information about your Metabase Installation:

  • Your browser and the version: Brave latest
  • Your operating system: Ubuntu 20.04.4
  • Your databases: Postgres 14
  • Metabase version: 1.42.3
  • Metabase hosting environment: Docker
  • Metabase internal database: Postgres 14

Severity
Cosmetic

Additional context
NA
@paoliniluis paoliniluis added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Native The SQL/native query editor .Frontend labels Apr 8, 2022
@flamber flamber added .CSS Difficulty:Easy Querying/Parameters & Variables Filter widgets, field filters, variables etc. labels Apr 9, 2022
@ariya ariya linked a pull request Apr 18, 2022 that will close this issue
SQL snippets should not always have scrollbars #21725
Merged
@ariya ariya self-assigned this Apr 18, 2022
ariya added a commit that referenced this issue Apr 18, 2022
@ariya
Repro #21550: SQL snippets show scrollbars when it isn't needed
0279919
@ariya ariya mentioned this issue Apr 18, 2022
Merged
ariya added a commit that referenced this issue Apr 18, 2022
@ariya
Repro #21550: SQL snippets show scrollbars when it isn't needed (#21730)
d0b077c
@ariya ariya added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 19, 2022
@flamber flamber modified the milestones: 0.42.5, 0.43 Apr 19, 2022
@deploysentinel deploysentinel bot mentioned this issue Aug 10, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Nov 15, 2023
Closed
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 4, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariya ariya

Labels
.CSS Difficulty:Easy .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

SQL snippets should not always have scrollbars metabase/metabase
3 participants
@ariya @flamber @paoliniluis