Loading spinners in filters don't appear anymore #25322
Assignees
Labels
.Frontend
Priority:P2
Average run of the mill bug
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
paoliniluis
added
Type:Bug
This was referenced Jan 11, 2023
This was referenced Oct 23, 2023
This was referenced Nov 30, 2023
nemanjaglumac
pushed a commit
that referenced
this issue
Dec 27, 2023
Add delay instead of throttle. Fixing a flake analyzed in this document. https://replayio.notion.site/dashboard-filters-reproductions-25322-loading-list-19324262f19d404ba03787c9f70968ab The test `25322-loading-list-values.cy.spec.js` has become flaky because the period of time to find loading-spinner element is too short. This is thanks to API response being fast. in the past, this was partially remedied by adding `setThrottle()` method to slow the API response down. while it is a good initial approach, it is not resilient to a situation when the data transfer size becomes smaller. I’m suggesting changing the method to setTimeout that will give the test enough time to catch the loading state. In the future, this particular test would be a good candidate for a component test as it is quite granular.
nemanjaglumac
pushed a commit
that referenced
this issue
Jan 4, 2024
Add delay instead of throttle. Fixing a flake analyzed in this document. https://replayio.notion.site/dashboard-filters-reproductions-25322-loading-list-19324262f19d404ba03787c9f70968ab The test `25322-loading-list-values.cy.spec.js` has become flaky because the period of time to find loading-spinner element is too short. This is thanks to API response being fast. in the past, this was partially remedied by adding `setThrottle()` method to slow the API response down. while it is a good initial approach, it is not resilient to a situation when the data transfer size becomes smaller. I’m suggesting changing the method to setTimeout that will give the test enough time to catch the loading state. In the future, this particular test would be a good candidate for a component test as it is quite granular.
nemanjaglumac
added a commit
that referenced
this issue
Jan 4, 2024
* Cypress E2E tests: Switch to using ReplayIO (#37228) * Remove Cypress cloud integration * Remove custom Chromium From now on, we'll use `replay-chromium` browser. * Start using ReplayIO for all E2E test runs * Use the default Chrome for Percy visual tests * Upload only failed Replay e2e recordings (#37235) * Fix flaky E2E #25322 reproduction (#37041) Add delay instead of throttle. Fixing a flake analyzed in this document. https://replayio.notion.site/dashboard-filters-reproductions-25322-loading-list-19324262f19d404ba03787c9f70968ab The test `25322-loading-list-values.cy.spec.js` has become flaky because the period of time to find loading-spinner element is too short. This is thanks to API response being fast. in the past, this was partially remedied by adding `setThrottle()` method to slow the API response down. while it is a good initial approach, it is not resilient to a situation when the data transfer size becomes smaller. I’m suggesting changing the method to setTimeout that will give the test enough time to catch the loading state. In the future, this particular test would be a good candidate for a component test as it is quite granular. * Add repro #22702 to the flaky tests * Add map brush filter to the flaky tests --------- Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: Filip Hric <filip@filiphric.sk>
This was referenced Jan 11, 2024
This was referenced Feb 5, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In pre-44, we had a loading spinner to indicate that the filter values were being loaded
In 44, we don't show anything, and this is concerning for users with huge app db's where the queries take a long time
Logs
NA
To Reproduce
Expected behavior
bring back the spinners when things take time!
Screenshots
Above
Information about your Metabase Installation:
Severity
P2 (since it impacts our bigger customers)
Additional context
NA
The text was updated successfully, but these errors were encountered: