Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard opens in editing state with added card #26826

Closed
alxnddr opened this issue Nov 30, 2022 · 2 comments · Fixed by #29368
Closed

Dashboard opens in editing state with added card #26826

alxnddr opened this issue Nov 30, 2022 · 2 comments · Fixed by #29368
Assignees
@EmmadUsmani
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.47

Comments

@alxnddr
Copy link
Member

alxnddr commented Nov 30, 2022

Describe the bug
After creating a dashboard, saving it, and navigating to another one it opens the dashboard in the editing mode with a card added.

To Reproduce
Steps to reproduce the behavior:

  1. Create a dashboard D1 with any card
  2. Create a question Q1, save and add on a dashboard D2, save the dashboard
  3. In search find D1 and open it

Actual behavior
D1 has been opened in the editing mode with a Q1 card added

Expected behavior
It opens the D1 dashboard in the view mode, without any cards added

Video

Screen.Recording.2022-11-30.at.12.55.59.PM.mov

@flamber flamber added Priority:P2 Average run of the mill bug Reporting/Dashboards .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Dec 2, 2022
@flamber
Copy link
Contributor

flamber commented Dec 2, 2022

Remember similar problem was fixed a long time ago and fixed, but might have returned around the dashboard overhaul ~39.
Related to #23684

@karakanb
Copy link

We are having the same problem when we navigate to the other dashboard directly, e.g. if I navigate to a folder first and then go to a dashboard the issue doesn't occur, however if I just click a bookmarked dashboard it opens up directly in the edit mode.

Is there sth we can do to avoid this behavior?

nemanjaglumac added a commit that referenced this issue Jan 20, 2023
@nemanjaglumac
Repro #26826: Dashboard alien card [ci skip]
a01382c
@nemanjaglumac nemanjaglumac mentioned this issue Jan 20, 2023
Merged
nemanjaglumac added a commit that referenced this issue Jan 20, 2023
@nemanjaglumac
Repro #26826: Dashboard alien card (#27805)
5177fd3
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jan 20, 2023
nemanjaglumac added a commit that referenced this issue Jan 22, 2023
@nemanjaglumac
Repro #26826: Dashboard alien card (#27805)
e8fba8a
nemanjaglumac added a commit that referenced this issue Jan 23, 2023
@nemanjaglumac
🍒 Backport repros from 2023-01-20 (#27818)
5340f91 
* Repro #27768: CC dashboard filter appears disconnected (#27791)

* Repro #25189: CC referencing a base column dropped in nested question (#27798)

* Repro #26826: Dashboard alien card (#27805)
@alxnddr alxnddr self-assigned this Mar 2, 2023
@EmmadUsmani EmmadUsmani assigned EmmadUsmani and unassigned alxnddr Mar 10, 2023
chalenge added a commit to faros-ai/metabase that referenced this issue Mar 14, 2023
@chalenge @metabase-bot
@jeff-bruemmer @nllho @paoliniluis @nemanjaglumac @kulyk @ranquild @dpsutton @ariya @noahmoss @calherries @tsmacdonald @alxnddr @npfitz
Upgrade to v1.45.3 (#10)
0ff99ce 
* docs - add section to dashboard subscriptions on permissions (metabase#27662) (metabase#27736)

* add section to dashboard subscriptions on permissions

* feedback from Luiz

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* docs - data model admin settings (metabase#27648) (metabase#27739)

Co-authored-by: Natalie <nat@metabase.com>

* note on breadcrumbs (metabase#27726) (metabase#27753)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Upgrading storybook to latest stable version (metabase#27679) (metabase#27758)

Co-authored-by: Luis Paolini <paoliniluis@gmail.com>

* docs - notes on allowed domains (metabase#27771) (metabase#27773)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* docs - update jwt (metabase#27755) (metabase#27778)

Co-authored-by: Natalie <nat@metabase.com>

* 🍒 Backport repros from 2023-01-20 (metabase#27818)

* Repro metabase#27768: CC dashboard filter appears disconnected (metabase#27791)

* Repro metabase#25189: CC referencing a base column dropped in nested question (metabase#27798)

* Repro metabase#26826: Dashboard alien card (metabase#27805)

* Fix `LogoBadge` `dark` prop value (metabase#27796) (metabase#27822)

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

* Fix the test (metabase#27826) (metabase#27834)

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* Fix failing bigquery test (metabase#27837) (metabase#27840)

Bigquery was checking that we can set a project-id in the db details of
a bigquery database. Normally this comes from the json token:

```
export MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON='{
  "type": "service_account",
  "project_id": "metabase-bigquery-driver", // <- ordinarily source of truth
  "private_key_id": "keykeykeykeykeykeykeykey",
  "private_key": "-----BEGIN PRIVATE KEY----- ...."
```

The db details normally connects to project-id
"metabase-bigquery-driver" and this test swaps out to
"bigquery-public-data" with a schema filter on chicago_taxi_trips.

to prove it works it selects from that dataset:

```
(mt/first-row
  (mt/run-mbql-query taxi_trips
    {:filter [:= [:field (mt/id :taxi_trips :unique_key) nil]
                 "67794e631648a002f88d4b7f3ab0bcb6a9ed306a"]}))
```

The test fails because this row seems to no longer be in the
results. The query isn't failing, it's just returning no rows (and
presumably because the row with this id from 2014 is no longer in the
dataset.)

I ran the same with with a limit 4, see it's working and grab one of
those rows and use the id as in the filter clause.

old: "67794e631648a002f88d4b7f3ab0bcb6a9ed306a" ("2014-01-12T00:45:00Z")
new: "ff0b96c0cada768361b1c9341e11905254644afb" ("2016-09-20T07:15:00Z")

Co-authored-by: dpsutton <dan@dpsutton.com>

* 🍒 Release workflow: handle the auto-adjustment of latest tag on Docker Hub (metabase#27811) (metabase#27848)

* docs - update timezones (metabase#27870) (metabase#27874)

Co-authored-by: Natalie <nat@metabase.com>

* manual backport of "docs - sumif" (metabase#27875)

* 🍒 Triggers docs update upon a release (metabase#27028) (metabase#27872)

* CI: Fix snowplow schema check (metabase#27884) (metabase#27888)

For some reasons, snowplow/igluctl as the service container in GitHub Action
workflow does not work anymore. Therefore, just invoke it directly with
`docker run`.

Co-authored-by: Ariya Hidayat <ariya@metabase.com>

* docs - update can't view or edit (metabase#27909) (metabase#27917)

Co-authored-by: Natalie <nat@metabase.com>

* Simplify dockerfile (metabase#27463) (metabase#27914)

Simplify the main Dockerfile removing custom circleci images

Co-authored-by: Luis Paolini <paoliniluis@gmail.com>

* docs - dash sub update (metabase#27925) (metabase#27933)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* backport subscription fix to 45 (metabase#27939)

* docs - update converttimezone (metabase#27930) (metabase#27949)

Co-authored-by: Natalie <nat@metabase.com>

* update links (metabase#27948) (metabase#27950)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* docs - update sql and error troubleshooting (metabase#27964) (metabase#27978)

Co-authored-by: Natalie <nat@metabase.com>

* db docs (metabase#27999)

* Backport metabase#27849 (metabase#27945)

* docs - fix typo (metabase#28007) (metabase#28011)

Co-authored-by: Natalie <nat@metabase.com>

* Include numThreadsAwaitingCheckoutDefaultUser in conn pool stats (metabase#28015) (metabase#28030)

This includes the stats in

```clojure
prometheus=> (troubleshooting/connection-pool-info)
{:connection-pools {"metabase-postgres-app-db" {:numConnections 4,
                                                :numIdleConnections 4,
                                                :numBusyConnections 0,
                                                :minPoolSize 1,
                                                :maxPoolSize 15,
                                                :numThreadsAwaitingCheckoutDefaultUser 0},
                    "db-52-postgres-clean" {:numConnections 1,
                                            :numIdleConnections 1,
                                            :numBusyConnections 0,
                                            :minPoolSize 1,
                                            :maxPoolSize 15,
                                            :numThreadsAwaitingCheckoutDefaultUser 0}}}
```

And thus ultimately in c3p0 stats:

```
_# HELP c3p0_num_threads_awaiting_checkout_default_user C3P0 Number of threads awaiting checkout
_# TYPE c3p0_num_threads_awaiting_checkout_default_user gauge
c3p0_num_threads_awaiting_checkout_default_user{database="metabase-postgres-app-db",} 0.0
c3p0_num_threads_awaiting_checkout_default_user{database="db-52-postgres-clean",} 0.0
```

Co-authored-by: dpsutton <dan@dpsutton.com>

* update api docs (metabase#28070)

* Fix zoom in drilldown for FKs (metabase#28022) (metabase#28085)

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* Enable and fix broken "edit history metadata" E2E tests (metabase#27889) (metabase#28086)

* Fix test filename

* Fix tests

---------

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

* db pages (metabase#28104)

* Category filters should always be multi-selectable (metabase#28096) (metabase#28115)

* Category filters should always be multi-selectable

[Fixes metabase#27393]

Co-authored-by: Tim Macdonald <tim@metabase.com>

* Fix ObjectDrill on queries with joined tables (metabase#28076) (metabase#28107)

* fix zoom on joined tables

* specs

* relocate section, fix link (metabase#28122) (metabase#28123)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Removing / fixing warnings when updating a dashboard filter and when you have incorrect link templates (metabase#28174) (metabase#28213)

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* [Docs] Migrate down command (metabase#28219)

* docs - clickhouse partner (metabase#28223) (metabase#28231)

* clickhouse from community to partner driver

* format

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* docs - migrate down docker (metabase#28226) (metabase#28235)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* docs - update field filters (metabase#28232) (metabase#28237)

Co-authored-by: Natalie <nat@metabase.com>

* Manual backport of various (blocked) Cypress changes (metabase#28222)

* [CI] Remap and update QA databases ports in Cypress tests (metabase#27886)

* Replace E2E repro for metabase#22822 with the FE unit test (metabase#28041)

* Repro metabase#26571: Do not show x-rays if feature is disabled (metabase#28130)

* Repro metabase#25988: Cannot reference nested question as native subquery (metabase#28135)

* Repro metabase#25715: Blank admin panel page for `null` database details (metabase#28138)

* [E2E] Make sure we can add Mongo using its connection string (metabase#28087)

* Backport "no native drill fallback when embedded" (metabase#28264)

* no native drill fallback when embedded (metabase#28243)

* docs - update embedding comparison (metabase#28276) (metabase#28308)

Co-authored-by: Natalie <nat@metabase.com>

* Fix links (metabase#28339) (metabase#28340)

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* docs - update signed embedding parameters (metabase#28317) (metabase#28390)

Co-authored-by: Natalie <nat@metabase.com>

* Backport E2E reproductions (metabase#28398)

* Repro metabase#25156: Handle invalid x-axis scale (metabase#28260)
* Repro metabase#27873: Missing group by column from the joined table (metabase#28262)
* Repro metabase#28218: Cannot reference native question with semicolon (metabase#28265)
* Repro metabase#28193: Cannot use custom column with models (metabase#28330)

[ci skip]

* [CI] Fix syntax in rerun workflows logic (metabase#28400) (metabase#28401)

[ci skip]

* 🍒 Various CI fixes and improvements from `master` (metabase#28399)

* 🍒 Backport more flake fixes (metabase#28421)

* [E2E] Fix `notifications` flake (metabase#28408)

* [E2E] Fix native field filter related flakes (metabase#28410)

* Upgrade `babel-loader` to 9.1.2 (metabase#28430)

Node 18 was breaking `build-static-viz` prior to this commit.
`Error: error:0308010C:digital envelope routines::unsupported`

* [CI] Fix Google related drivers classpath test (metabase#28412) (metabase#28429)

---------

Co-authored-by: metabase-bot[bot] <109303359+metabase-bot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Co-authored-by: Natalie <nat@metabase.com>
Co-authored-by: Luis Paolini <paoliniluis@gmail.com>
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Co-authored-by: dpsutton <dan@dpsutton.com>
Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: Tim Macdonald <tim@metabase.com>
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
@EmmadUsmani EmmadUsmani mentioned this issue Mar 20, 2023
Merged
@EmmadUsmani EmmadUsmani added this to the 0.47 milestone Mar 20, 2023
@deploysentinel deploysentinel bot mentioned this issue Apr 4, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Apr 18, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Apr 26, 2023
Merged
1 task
@deploysentinel deploysentinel bot mentioned this issue Aug 9, 2023
Merged
This was referenced Aug 30, 2023
Closed
Merged
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EmmadUsmani EmmadUsmani

Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.47
Development

Successfully merging a pull request may close this issue.

fix dashboard opening in editing state when it shouldn't metabase/metabase
6 participants
@flamber @alxnddr @karakanb @nemanjaglumac @EmmadUsmani @darksciencebase