Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in mini bar chart toggle on dashcard viz settings #30966

Closed
noahmoss opened this issue May 23, 2023 · 1 comment · Fixed by #31665
Closed

Bug in mini bar chart toggle on dashcard viz settings #30966

noahmoss opened this issue May 23, 2023 · 1 comment · Fixed by #31665
Assignees
Labels
Customization/Formatting Priority:P2 Average run of the mill bug Type:Bug Product defects
Milestone

Comments

@noahmoss
Copy link
Member

Describe the bug

On a dashboard card, if you toggle the mini bar chart viz setting for a column, it requires two separate clicks to enable/disable. The first click moves the toggle but doesn't affect the setting, and the second click affects the setting.

To Reproduce

  1. Create a dashboard and add a table card to it
  2. Go to Visualization Options (on the dashcard) and click the ... on a numerical column to open its viz settigns
  3. Try to toggle the mini bar chart option

Expected behavior

Toggle should work like normal

Logs

No response

Information about your Metabase installation

Current master

Severity

P3, but weird

Additional context

No response

@noahmoss noahmoss added Type:Bug Product defects .Needs Triage labels May 23, 2023
@npfitz npfitz self-assigned this May 23, 2023
@noahmoss noahmoss added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Customization/Formatting and removed .Needs Triage labels May 23, 2023
@npfitz npfitz added Priority:P2 Average run of the mill bug and removed Priority:P3 Cosmetic bugs, minor bugs with a clear workaround labels May 24, 2023
@npfitz
Copy link
Contributor

npfitz commented May 24, 2023

This is actually a slightly larger issue than it initially appeared to be. Due to my terrible code with the settings popover widget, changing any nested setting on a dashcard is very, very annoying and prone to not really working.

@npfitz npfitz added this to the 0.47 milestone Jun 29, 2023
This was referenced Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization/Formatting Priority:P2 Average run of the mill bug Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants