Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard loses effective filter values when auto-apply is turned off #34382

Closed
zbodi74 opened this issue Oct 4, 2023 · 0 comments · Fixed by #34399
Closed

Dashboard loses effective filter values when auto-apply is turned off #34382

zbodi74 opened this issue Oct 4, 2023 · 0 comments · Fixed by #34399
Assignees
Labels
.Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards Type:Bug Product defects
Milestone

Comments

@zbodi74
Copy link

zbodi74 commented Oct 4, 2023

Describe the bug

When returning to a dashboard from a card the values of filters are not restored if Auto-apply filters is turned off on the dashboard.

To Reproduce

  1. Create a saved question (e.g. select Products from the sample database), save it and add it to a dashboard.
  2. Add a dashboard filter and connect it to the question (e.g. add Category).
  3. Turn Apply filter values off for the dasboard.
  4. Set a value for the filter, and apply it.
  5. Open the card from the dashboard, notice that the filter values remain in effect.
  6. Click the blue left arrow button to return to the dashboard (the Metabase one, not the browser back button).
  7. (!) The filter values are cleared in the dashboard filters.
  8. (!) Reload the page, and the card also returns to an unfiltered state.

Expected behavior

The applied filter values should be retained on return from a card.

Logs

n/a

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-GB",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.20.1+1",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "11.0.20.1",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.20.1+1",
    "os.name": "Linux",
    "os.version": "5.10.192-183.736.amzn2.x86_64",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "bigquery-cloud-sdk",
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "14.7"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.5.4"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2023-09-18",
      "tag": "v1.47.2",
      "branch": "release-x.47.x",
      "hash": "536c24c"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

A severe issue for some of our users.

Additional context

Screen recording: filters are correctly restored when auto_apply_filters is set, and lost when the flag is unset.
https://github.com/metabase/metabase/assets/11080638/54ef0114-8a36-4044-8a91-ac525e1e6c7f

No response

@zbodi74 zbodi74 added Type:Bug Product defects Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Needs Triage labels Oct 4, 2023
@zbodi74 zbodi74 added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Escalation labels Oct 4, 2023
@uladzimirdev uladzimirdev self-assigned this Oct 5, 2023
@uladzimirdev uladzimirdev added this to the 0.47.4 milestone Oct 6, 2023
This was referenced Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Escalation Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants