Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static/Public embeds fail to load dashboard when one of the cards fails to load due to missing filter value. #34954

Closed
Tony-metabase opened this issue Oct 23, 2023 · 3 comments · Fixed by #35851
Assignees
Labels
Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) .Team/Embedding Type:Bug Product defects Visualization/
Milestone

Comments

@Tony-metabase
Copy link
Contributor

Describe the bug

Static/Public embeds fail to load dashboard when one of the cards fails to load due to missing filter value.

To Reproduce

  1. Go to New -> SQL Query -> Select * from products Where category = {{something}} -> Save
image
  1. Add it to a Dashboard -> Add a filter to the card:
image
  1. Go to Edit -> Click on the Card and edit visualisation option -> Enable Hide this card if there are no results
image
  1. Go to Share -> Enable Public Sharing (this also happens for Static Embedding) -> Go to the public URL and notice a blank screen:
image

The dashboard is able to load at first but if you notice the network calls when the error due to filter not being selected for the card occurs it simply breaks the screen:

image

Something similar to Metabase should occur like the following:

image

Even though the error message something is gone wrong is very misleading instead of a please select filter for something

Expected behavior

Cannot share an image here but i described it in the Reproduce Section

Logs

None that are relevant even though the actual error is:

Cannot run the query: missing required parameters: #{\"something\"}

Even though it's not specific to that error but how the frontend behaves due to that error

Information about your Metabase installation

1.47.5 ann master

Severity

This completely blocks the usage of 2 important features

Additional context

The only workaround is to put a default value but if you decide to remove it from the URL then you end up breaking the visual again

@Tony-metabase Tony-metabase added Type:Bug Product defects Priority:P2 Average run of the mill bug Visualization/ Reporting/Dashboards .Frontend Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding labels Oct 23, 2023
@paoliniluis paoliniluis added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Oct 23, 2023
@albertoperdomo
Copy link
Member

@cdeweyx Is this for Dashviz team or for us?

@cdeweyx
Copy link

cdeweyx commented Nov 9, 2023

@cdeweyx Is this for Dashviz team or for us?

@albertoperdomo looks embedding-specific so my thinking is #team-embedding

@WiNloSt
Copy link
Member

WiNloSt commented Nov 15, 2023

This could either be fixed on FE or BE. The reason is that when query from our dashboard. BE will send data in the response
image

but not when we're querying from public embed (public link) or static embed
image

FE fix: Account for the missing data key
BE fix: send data: {rows: [], cols: []} like the dashboard endpoints.

This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) .Team/Embedding Type:Bug Product defects Visualization/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants