-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static/Public embeds fail to load dashboard when one of the cards fails to load due to missing filter value. #34954
Labels
Embedding/Public
Simple public iframe embeds
Embedding/Static
Static embedding, previously known as signed embedding
Priority:P2
Average run of the mill bug
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
Reporting/Dashboards
.Reproduced
Issues reproduced in test (usually Cypress)
.Team/Embedding
Type:Bug
Product defects
Visualization/
Milestone
Comments
Tony-metabase
added
Type:Bug
Product defects
Priority:P2
Average run of the mill bug
Visualization/
Reporting/Dashboards
.Frontend
Embedding/Public
Simple public iframe embeds
Embedding/Static
Static embedding, previously known as signed embedding
labels
Oct 23, 2023
paoliniluis
added
the
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
label
Oct 23, 2023
@cdeweyx Is this for Dashviz team or for us? |
@albertoperdomo looks embedding-specific so my thinking is #team-embedding |
1 task
1 task
This was referenced Jan 11, 2024
This was referenced May 8, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Embedding/Public
Simple public iframe embeds
Embedding/Static
Static embedding, previously known as signed embedding
Priority:P2
Average run of the mill bug
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
Reporting/Dashboards
.Reproduced
Issues reproduced in test (usually Cypress)
.Team/Embedding
Type:Bug
Product defects
Visualization/
Describe the bug
Static/Public embeds fail to load dashboard when one of the cards fails to load due to missing filter value.
To Reproduce
Select * from products Where category = {{something}}
-> SaveHide this card if there are no results
The dashboard is able to load at first but if you notice the network calls when the error due to filter not being selected for the card occurs it simply breaks the screen:
Something similar to Metabase should occur like the following:
Even though the error message
something is gone wrong
is very misleading instead of aplease select filter for something
Expected behavior
Cannot share an image here but i described it in the Reproduce Section
Logs
None that are relevant even though the actual error is:
Cannot run the query: missing required parameters: #{\"something\"}
Even though it's not specific to that error but how the frontend behaves due to that error
Information about your Metabase installation
Severity
This completely blocks the usage of 2 important features
Additional context
The only workaround is to put a default value but if you decide to remove it from the URL then you end up breaking the visual again
The text was updated successfully, but these errors were encountered: