Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 backported "Bump jetty-server to 9.4.48.v20220622" #24488

Closed
wants to merge 16 commits into from
Closed

🤖 backported "Bump jetty-server to 9.4.48.v20220622" #24488

wants to merge 16 commits into from

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Aug 1, 2022

@metabase-bot metabase-bot bot enabled auto-merge (squash) August 1, 2022 18:58
metabase-bot bot and others added 3 commits August 1, 2022 19:06
@metabase-bot @ranquild
Update deps (#24485) (#24486)
5dc199a 
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
@metabase-bot @calherries @qnkhuat
Fix for #23940: Error sending emails when reply-to setting contains e…
4088f7e 
…mpty string (#23942) (#24180)

* Update the reply-to setting component to never allow it's value to be [""]

* Fix e2e test

* Validate email-reply-to setting to be a list of email addresses

* Fix validation copy

* Fix copy on reply-to setting description

* Update src/metabase/email.clj

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
@metabase-bot @ranquild
Fix native time tooltip formatting (#24185) (#24221)
a5c6bf7 
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
@codecov
Copy link

codecov bot commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #24488 (fd04405) into release-x.44.x (e85e261) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head fd04405 differs from pull request most recent head ac6b735. Consider uploading reports for the commit ac6b735 to get more accurate results

@@                Coverage Diff                 @@
##           release-x.44.x   #24488      +/-   ##
==================================================
- Coverage           64.94%   64.94%   -0.01%     
==================================================
  Files                2742     2742              
  Lines               85046    85051       +5     
  Branches            10456    10454       -2     
==================================================
+ Hits                55233    55236       +3     
- Misses              25534    25538       +4     
+ Partials             4279     4277       -2
Flag Coverage Δ
back-end 85.58% <ø> (-0.01%) ⬇️
front-end 45.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/metabase/task/sync_databases.clj 77.08% <0.00%> (-3.48%) ⬇️
src/metabase/api/table.clj 97.00% <0.00%> (-0.02%) ⬇️
src/metabase/models/query.clj 89.79% <0.00%> (ø)
src/metabase/api/search.clj 87.24% <0.00%> (+0.31%) ⬆️
src/metabase/search/config.clj 100.00% <0.00%> (+1.04%) ⬆️
src/metabase/search/scoring.clj 97.66% <0.00%> (+1.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

github-actions bot and others added 12 commits August 1, 2022 16:26
@github-actions @gusaiani
Ensure currency symbols are shown in table data if settings say so (#…
d9ed256 
…23874) (#24187)

Co-authored-by: Gustavo Saiani <gustavo@poe.ma>
@metabase-bot @luizarakaki @jeff-bruemmer
Update scanning process details (#24105) (#24121)
f7baa50 
* Update scanning process details

Product doc:
https://www.notion.so/metabase/Overhaul-field-values-scan-query-and-filter-widget-behavior-edc24a6ac4b54093ac1c5133345dcb3c#ab7c3aa6b5ce4d0aa39ef8edca1d0bdf

Relevant PRs:
#23138
#23403

* we trigger only one query

* revision

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
@metabase-bot @nemanjaglumac
Unskip repro for #20809 (#24275) (#24288)
46be3f7 
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@metabase-bot @iethree
🤖 backported "Large category picker in bulk filter modal" (#24490)
4bf28e8 
* Create Large Category Picker (#24378)

* prettier fix

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Co-authored-by: Ryan Laurie <iethree@gmail.com>
@metabase-bot @iethree @ranquild
🤖 backported "Bulk Filter Modal: Side Nav" (#24495)
32ba79c 
* move table nav to the side (#24493)

* Fix feature check

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
@metabase-bot @iethree
Bulk Filter Modal: New Field Layout (#24492) (#24498)
93afab7 
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
@metabase-bot @iethree @ranquild
🤖 backported "Fix Table Names Not Appearing in Dimension Option Lists" (
2f326ec 
#24467)

* get table name from a non-expression column (#24439)

* prettier fix

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Co-authored-by: Ryan Laurie <iethree@gmail.com>
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
@iethree
Back to light input borders (#24435) (#24470)
5369eec 
* remove border-dark
@metabase-bot @iethree @ranquild
🤖 backported "Hide Popover suggestions on item removal" (#24479)
5d16ee4 
* dont show suggestions on token removal (#24442)

* prettier fix

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Co-authored-by: Ryan Laurie <iethree@gmail.com>
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
@rlotun @diogormendes
Bump jetty-server to 9.4.48.v20220622 (#24482)
6a28022
@diogormendes
Merge remote-tracking branch 'origin/backport-56be37c4ec0f255a1f4699d…
8bdac5f 
…bdedf80a1d08532f3' into backport-56be37c4ec0f255a1f4699dbdedf80a1d08532f3
@diogormendes
Revert "Merge remote-tracking branch 'origin/backport-56be37c4ec0f255…
ac6b735 
…a1f4699dbdedf80a1d08532f3' into backport-56be37c4ec0f255a1f4699dbdedf80a1d08532f3"

This reverts commit 8bdac5f.
auto-merge was automatically disabled August 2, 2022 11:57

Pull request was closed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Notifying subscribers in CODENOTIFY files for diff e85e261...ac6b735.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/lib/apply_axis.js
frontend/src/metabase/visualizations/lib/settings/column.js
@ranquild frontend/src/metabase/lib/colors/palette.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@rlotun rlotun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlotun @diogormendes @iethree