Skip to content

pressing enter in /account/profile #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2017
Merged

pressing enter in /account/profile #1855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6578fc
make remove button on email and website work
simbabque Feb 26, 2017
95ec425
fix horizontal spacing for repeatable fields
simbabque Feb 26, 2017
7e2baa4
make sure all buttons never behabve like submit
simbabque Feb 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions root/account/profile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ <h4 class="alert-heading">Error</h4>
<div class="input-group">
<input type="email" class="form-control" name="email" value="<% author.email.shift %>" />
<span class="input-group-btn">
<button class="btn search-btn" onclick="return addField('email')">add</button>
<button class="btn search-btn" type="button" onclick="return addField('email')">add</button>
</span>
</div>
<% FOREACH email IN author.email -%>
<div class="input-group" style="padding-top:15px;">
<input type="email" class="form-control" name="email" value="<% email %>" />
<span class="input-group-btn">
<button class="btn search-btn" onclick="return removeDiv(this)">remove</button>
<button class="btn search-btn" type="button" onclick="return removeDiv(this)">remove</button>
</span>
</div>
<% END -%>
Expand All @@ -73,15 +73,15 @@ <h4 class="alert-heading">Error</h4>
<div class="input-group">
<input type="url" class="form-control" name="website" value="<% author.website.shift %>" />
<span class="input-group-btn">
<button class="btn search-btn" onclick="return addField('website')">add</button>
<button class="btn search-btn" type="button" onclick="return addField('website')">add</button>
</span>
</div>
<% FOREACH website IN author.website -%>
<!-- <br> -->
<div class="input-group" style="padding-top:15px;">
<input type="url" class="form-control" name="website" value="<% website %>" />
<span class="input-group-btn">
<button class="btn search-btn" href="" onclick="return removeDiv(this)">remove</a></button>
<button class="btn search-btn" type="button" href="" onclick="return removeDiv(this)">remove</a></button>
</span>
</div>
<% END -%>
Expand Down Expand Up @@ -294,7 +294,7 @@ <h4 class="alert-heading">Error</h4>
function addField(id) {
var input = $('input[name="' + id + '"]').last();
var container = input.parent().parent();
container.append('<br><div class="input-group"><input type="text" class="form-control" name="' + id + '" /><span class="input-group-btn"><button class="btn search-btn" onclick="return removeLabel(this.parentNode)">remove</button></span></div>');
container.append('<div class="input-group"><input type="text" class="form-control" name="' + id + '" /><span class="input-group-btn"><button type="button" class="btn search-btn" onclick="return removeDiv(this.parentNode)">remove</button></span></div>');
var add = container.children().last();
add.slideDown();
return false;
Expand Down
10 changes: 10 additions & 0 deletions root/static/less/account.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,16 @@
}
}

.repeatable .form-group {
.input-group {
margin-bottom: 15px;
}

&:last-child {
margin-bottom: 0;
}
}

// The last-updated text needs better alignment
p.checkbox {
padding-left: 0;
Expand Down