pressing enter in /account/profile #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removeLabel JS function seems to not be used at all any more. It operates on elements with the .control class, but that also seems not to be used at all. There are some references to that class in root/static/openlayers/OpenLayers.js, but I am not sure if that's related. Both the JS function as well as the corresponding less code in root/less/account.less can possibly be removed.
Some browsers apparently think that a button is a submit-like button by default. If there's JS on that button, it gets executed when one presses enter in the form. It seems to pick the first button to occur. This only happens in some browsers, and lead to additional email rows being added whenever enter was pressed in any form field. Also see http://stackoverflow.com/a/13534643/1331451. This changes the behavior insofar that now whenever enter is pressed, the form is submitted and the profile gets saved. Fixes metacpan#1847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1847. It was mostly related to the default behavior of some browsers. Possibly that's why it might not have shown up for everyone.