Map numpy ops to GraphBLAS ops by default, and a few fixes. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
land, lor, and lxor can return dtypes other than BOOL. This has been fixed. Also, creating a semiring from a monoid that has coercions has been fixed.
We assume all monoids commute (not strictly true, but this is how they're typically used in GraphBLAS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
land, lor, and lxor can return dtypes other than BOOL. This has been fixed.
Also, creating a semiring from a monoid that has coercions has been fixed.
When the next SuiteSparse:GraphBLAS is released, I think we'll want to test the input and output types of all our operators using the new introspection function.
@jim22k can you think of a better name than
mapnumpyfor the config to control whether e.g.binary.numpy.addmaps tobinary.plusor not?