improved portability of first/last Aggregators and restored Matrix.diag() #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParticularMiner
force-pushed
the
first_last
branch
from
917b3b8 to
42ec3bb
Compare
ParticularMiner
force-pushed
the
first_last
branch
from
42ec3bb to
ca40614
Compare
jim22k
approved these changes
Mar 24, 2022
Member
|
Hooray, thanks @ParticularMiner 🎉 |
Closed
eriknw
reviewed
Mar 24, 2022
| index = step1[0].new().value | ||
| if index is None: | ||
| # `==` instead of `is` automatically triggers index.compute() in dask-grblas: | ||
| if index == None: # noqa |
Member
There was a problem hiding this comment.
We might want to consider supporting e.g. t = v[s].new() where s and t are both gb.Scalars that are empty. Currently, scalar indices are GrB_Index type, not GrB_Scalar type, so this isn't supported by SuiteSparse:GraphBLAS. But, we could support this in grblas and dask-grblas, and doing so would allow us to avoid dask-grblas computing during index == None.
Contributor
Author
There was a problem hiding this comment.
Great idea from an optimization standpoint!
Heh, this automatically means also dealing with lists of indices of different types, like v[2 s 1 None t].new().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dask_grblas.my_matrix.diag(k, ...)(extraction of a diagonal from aMatrixto aVector) which helps enable the support fordask-grblas. This specification was removed earlier in PR added X.diag(k, ...) where type(X) in {Vector, Matrix} #186 .Feel free to edit this PR if anything is amiss!