Adding design for hardware devices info collection #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtantsur
reviewed
Apr 15, 2019
dtantsur
reviewed
Apr 15, 2019
dtantsur
reviewed
Apr 15, 2019
dtantsur
reviewed
Apr 15, 2019
dtantsur
reviewed
Apr 15, 2019
dhellmann
reviewed
Apr 15, 2019
elfosardo
commented
Apr 16, 2019
elfosardo
force-pushed
the
hardware-inventory-design
branch
from
d5c9b49
to
0a0fafe
Compare
elfosardo
changed the title
elfosardo
force-pushed
the
hardware-inventory-design
branch
from
0a0fafe
to
debfb85
Compare
dhellmann
reviewed
Apr 16, 2019
dhellmann
reviewed
Apr 16, 2019
elfosardo
force-pushed
the
hardware-inventory-design
branch
from
debfb85
to
7faa527
Compare
dhellmann
requested changes
Apr 23, 2019
dhellmann
reviewed
Apr 23, 2019
elfosardo
force-pushed
the
hardware-inventory-design
branch
from
7faa527
to
034823c
Compare
dtantsur
approved these changes
Apr 24, 2019
zaneb
reviewed
May 28, 2019
|
@dhellmann please let me know if there's anything more to add when you get a chance |
There are 2 comments open on the review that ask for more details, and I think we should answer both before proceeding. |
Addign design to implement automated and manual hardware devices info collection, including health data.
elfosardo
force-pushed
the
hardware-inventory-design
branch
from
034823c
to
a14b22f
Compare
dhellmann
approved these changes
Jun 24, 2019
|
|
||
| ## Table of Contents | ||
|
|
||
| * [Title](#title) |
There was a problem hiding this comment.
It looks like the inline stuff for gh-md-toc is gone and this may be out of date. We can fix that with a follow-up patch.
zaneb
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding design to implement automated and manual hardware devices info collection, including health data.