Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/tools: reduce required Go version #419

Merged
merged 1 commit into from
May 6, 2024
Merged

hack/tools: reduce required Go version #419

merged 1 commit into from
May 6, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented May 3, 2024

1.22 is very new and is not yet available in most distributions.
It seems that 1.21 works fine.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2024
@dtantsur
Copy link
Member Author

dtantsur commented May 3, 2024

See #420

@dtantsur dtantsur closed this May 3, 2024
@dtantsur dtantsur deleted the hack-tools branch May 3, 2024 15:04
@dtantsur dtantsur restored the hack-tools branch May 6, 2024 08:36
@dtantsur dtantsur reopened this May 6, 2024
lentzi90
lentzi90 reviewed May 6, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@kashifest
Copy link
Member

/hold
This perhaps passed the tests since we have a GO_VERSION variable set in the netlify settings and the build used go 1.22.2 anyhow, I will remove it now. I am anyhow making this variable to be set via the config file here #421. Here is the build which passed for this test:

Screenshot 2024-05-06 at 12 32 16

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@kashifest
Copy link
Member

/hold cancel
I have removed it from the settings, lets do a repush of this branch to see if the build is still happy.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@dtantsur
hack/tools: reduce required Go version
52c8863 
1.22 is very new and is not yet available in most distributions.
It seems that 1.21 works fine.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@kashifest
Copy link
Member

Build is happy
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@metal3-io-bot metal3-io-bot merged commit c46492c into metal3-io:main May 6, 2024
6 checks passed
@dtantsur dtantsur deleted the hack-tools branch May 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @metal3-io-bot @kashifest @lentzi90