-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French SI Brochure feedback from BIPM (pages 4-20) #40
Comments
|
rb: Not that BIPM have said this explicitly (and BIPM must learn that they need to!!), but it appears that instead of using "Article" for clause references, BIPM uses "Chapître/Chapter" for first level clause references, and "Section" for subclauses. |
@opoudjis @manuel489 Please note that I've reassigned these issues to
It's a bug in FOP: https://issues.apache.org/jira/browse/FOP-2969 In the source xml there are a characters with accent/acutes as separated characters, i.e. for example: In normal case - Latin Small Letter E With Acute has a hex code E9: but in the source adoc and xml it encoded as e and hex code 301 (Combining Acute Accent) These chars should be replaced to simple characters (i.e. as one char). Resulted PDF - comparing between old and updated (copied from word to xml directly) chars: |
Wow! Yes, although Unicode processing should be dealing with that, because those two character sequences are formally equivalent, this is indeed a problem, and precomposed characters are always preferred where available. @manuel489 You are already editing the documents; can you fix this, or do you need me to? |
Actually, don't worry: I'm going to apply Unicode Normalisation to the XML generation in standoc. @Intelligent2013 I will need you to confirm that it has worked. @manuel489 don't touch anything. |
Turns out, it is any French text I have entered, in Mac Terminal: Mac Terminal is entering decomposed Unicode text. So that applies to the YAML tables and to the boilerplate. I will introduce normalisation anyway, since this can happen at any stage. I also am changing ALL METANORMA FILES to NFC (the correct, composed Unicode normalisation). |
These are not part of adoc file. This appears on the page right after the front page. @opoudjis?
We can fix this by applying some other font, such as
I added a cross-reference.
Fixed.
I removed blank spaces between
As @manuel489 wrote in #41 (comment), this is not fixable by markup, unless we insert a literal symbol. @ronaldtse?
Fixed.
As I understand, this will be solved in metanorma/metanorma-bipm#44. We removed manual digits separation from adoc.
Fixed.
I removed blank spaces between
Fixed. |
That is deliberate by me, and I strongly urge us not to fix this. The boilerplate we are including in our generated documents is not intended just for the single document of the SI Brochure, but for all documents produced by BIPM. We cannot just insert the title of the document, because in French we don't know what the gender of the document title is (La brochure, but le rapport). And frankly, I do not believe that inserting the document title in the boilerplate is worth us adding a document title gender attribute.
It's boilerplate. Fixed. |
@anermina @manuel489 the italicisation of Greek letters within mathematical expressions will be addressed in metanorma/metanorma-standoc#367. (Mathematical formatting tools default to [crude] English conventions of italicising all Greek and Roman letters in mathematical tools, and only TeX allows that to be configured differently, including to French practice, which does not italicise Greek lowercase letters. We will need to address this by forced override of italicisation in MathML.) |
Updated PDF: #24 (comment) |
Wow! Thanks @anermina for double-checking! The reason I marked it as not-fixed issue is because I compared it with the font of the original file and they are different: left: generated, right: original But yeah, that is probably because we are using a different set of fonts. Which in this case, the difference between italics and not italics is a little bit more subtle (but definitely noticeable): above: italics, bottom: not italics Thanks! |
So, discarding the issues mentioned above, the table results in:
|
No problem @manuel489 , I just remembered seeing this in some of the previous checks :) |
p. 4: #40 (comment) . I am currently declining to implement, as I want strongly boilerplated text. p. 9: There is currently no index anyway; metanorma/metanorma-bipm#67 is the task to create it, and it is a big undertaking p. 10. The accents are supposed to have been fixed, by me applying Unicode Normalisation to the text generation; will need to investigate what has happened. p. 15, 16: to investigate |
p. 10, clearly I missed this file. Fixed. |
p. 15. Boldface applied to text does not apply to the MathML it contains; so any boldface has to be indicated explicitly on the AsciiMath: the MathML processor simply ignores the formatting of its context. (I don't think that's the case in Word, but then, Word is not an exemplar of mathematical word processing.) Unfortunately this means you're also going to have to insert Moreover, nesting of font styles tends not to work. So you get something disgusting to data enter like:
AND, any such overrides of style are themselves going to be overridden by the styles we insert to deal with upright Greek characters. So we can't make Greek characters boldface without more postprocessing. AND in JEuclid (PDF), boldface is being ignored for exponents. As a result, what I'm getting with the data entry above is: PDF: HTML: I have no idea why random letters H and W are not being bolded by jEuclid. This is enough of a disaster to push back on the use of boldface for emphasising mathematical text, which is frankly ugly to begin with. I do not think we should be proceeding with this. |
p. 16. There are two different things going on here. First: If this were a Second: font commands will work in the general case; e.g. This arguably annuls any font nesting we might try to introduce; but we have just seen that font nesting in MathML does not work anyway. Addressing the second, and inviting editors to insert explicit font overrides in cases like this. The first needs further investigation of the asciimath gem, but might not be tractable. |
First issue: Omega is being parsed by AsciiMath as an operator, because, well, it is an operator in mathematics: https://en.wikipedia.org/wiki/Omega#The_symbol_Ω_(uppercase_letter) ; e.g.
Greek Letters that are treated by AsciiMath as operators are: https://github.com/asciidoctor/asciimath/blob/7b48295ae5c5bfc3f4679daa9ca322f69aec1931/lib/asciimath/markup.rb Γ, Δ, Θ, Λ, Ξ, Π, Σ, Ω The French localisation of mathematical variables is not going to catch operators We can override this behaviour by postprocessing, to say that if any of those operator letters is not followed by parentheses in the same MathML expression, they should be switched to This is very convoluted; let me summarise it.
We have the unfortunate situation that:
The markup |
Ok, italic markup for |
@opoudjis, just to confirm, should we proceed with boldface markup in math environment? |
One remaining issue in this thread:
|
@opoudjis , there is another issue that weren't before and I missed to report. An additional entry in the index, And it takes a whole page for itself. |
@manuel489 The references are correctly deleted from the documents within the bilingual brochure folder. To explain:
Because the references are being deleted in the collection brochure, there is nothing for me to fix. |
Ok @opoudjis, thank you for your clarification. (And sorry for the bothering.) |
Indexing is addressed in metanorma/metanorma-bipm#67. Closing this ticket. |
The text was updated successfully, but these errors were encountered: