Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-English language issues with generated MN XML Table of Contents #300

Closed
ronaldtse opened this issue Dec 2, 2019 · 4 comments
Closed
Assignees
Labels

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Dec 2, 2019

This issue shows up here: metanorma/mn-native-pdf#14

The source files are at https://github.com/metanorma/mn-samples-iso

English version:
Screen Shot 2019-12-02 at 3 03 33 PM

Chinese version:
Screen Shot 2019-12-02 at 3 03 27 PM
Screen Shot 2019-12-02 at 3 06 25 PM

Notice that in the Chinese version:

  • "Contents" should have been in Chinese.
  • "Introduction" “引言” is given as a numbered section, but should have been unnumbered.
  • "Scope" “范围” is given as clause 3, but should have been clause 1.
  • Clause 2 "Bibliography" should be in Chinese.
  • Clause 3 should have been "Terms and definitions" “术语和定义” and the term clauses should not be listed in the TOC.
  • "Annex A (normative)" should be in Chinese.
  • "Bibliography" at the end should have been in Chinese.
@opoudjis
Copy link
Contributor

In reality, the internationalisation model needs to be revisited. The assumption to date has been that titles are internationalised on isodoc, but the PDF stylesheets being unencumbered by i18n, the titles need to be internationalised in XML, and any decision making based on title content needs to be moved to a type attribute on the clause.

@opoudjis
Copy link
Contributor

opoudjis commented Jul 13, 2020

The needed refactor is:

  1. Internationalisation needs to be defined as a class, with class inheritance, just as is now done with xrefs.
  2. There is only one internationalisation file, in isodoc class, and asciidoc class uses the isodoc internationalisation class.
  3. Titles need to be internationalised in XML generation, Loosen requirement of obligatory titles isodoc#171

Internationalisation also needs to be more thorough than it has been in the past, but this is a necessary first step.

@opoudjis
Copy link
Contributor

Refactor of 1, 2 is done. Now the fixes requested in December become dependent on metanorma/isodoc#171.

opoudjis added a commit to metanorma/isodoc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/isodoc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-standoc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-generic that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-csa that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-cc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-cc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-gb that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-iec that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-iec that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-ietf that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-iho that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-itu that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-itu that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-mpfa that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Jul 14, 2020
opoudjis added a commit to metanorma/metanorma-un that referenced this issue Jul 14, 2020
@opoudjis
Copy link
Contributor

opoudjis commented Jan 12, 2021

Only things remaining in PDF: "Contents" and "Page".

Have fixed "Contents" in HTML/DOC.

opoudjis added a commit that referenced this issue Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants