Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Fix opening an includedView after process creation #1282

Merged
merged 3 commits into from
Oct 20, 2017
Merged

Conversation

ottosichert
Copy link
Contributor

(See #1258)

@teosarca @metas-mk Please try out opening and closing all kind of modals and dialogs. Also you should notice that this PR fixes some minor issues such as losing selection and closing includedViews unintentionally when changing Table selection and back (works now)

@ottosichert
Copy link
Contributor Author

I tried following steps:

  • Open Picking Terminal (https://w101.metasfresh.com:8443/window/540345)
  • Select first item
  • Click quick action Pick
  • Modal opens
  • First item in table and includedView is already selected
  • Click quick action Open HU selection window
  • Select a TU in new includedView
  • Uncaught Error: InvalidStateError: The connection has not been established yet

I this supposed to work?

  • Open Picking Terminal (https://w101.metasfresh.com:8443/window/540345)
  • Select first item
  • Click quick action Pick
  • Modal opens
  • First item in table and includedView is already selected
  • Click drop down of quick actions
  • Click Pick to new HU
  • Select item in Packvorschrift-Produkt Zuordnung
  • Click Start
  • Selected item appears below item in includedView

Is this correct?

@teosarca teosarca merged commit 8f9c7d6 into master Oct 20, 2017
@teosarca teosarca deleted the dev-1258 branch October 20, 2017 07:18
includedTabsInfo: {},
triggerField: null
})
modal: Object.assign({}, state.modal, initialState.modal),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: use

modal: {
    ...state.modal,
    ...initialState.modal
}

We can do a refactoring specifically to replace all Object.assigns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it for consistency, but you are right we should use this in all occurences instead as we use babel's object-rest-spread already

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants