New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling methods while being offline are never executed #538

Closed
Mas-Tool opened this Issue Dec 10, 2012 · 6 comments

Comments

Projects
None yet
4 participants
@Mas-Tool

Mas-Tool commented Dec 10, 2012

I'm using the accounts-facebook to login my application and i noticed methods are not being called when being disconnected and reconnecting to a meteor application.

Steps to reproduce:

  1. Login using facebook account.
  2. Turn off the WIFI network (disconnects from the internet).
  3. Call a method using Meteor.call
  4. Turn on the WIFI network.

In this scenario (which is quite common) meteor tries to reconnect and login again in the background, but the old method calls and the new method calls are not executed.

@avital

This comment has been minimized.

Contributor

avital commented Dec 10, 2012

Please supply an app (ideally a full repository on Github that can be
cloned and immediately run) and exact reproduction steps (what do we click
on exactly or what do we run in the console exactly). Please describe the
precise observed state and expected state.

On Mon, Dec 10, 2012 at 2:19 PM, mastool notifications@github.com wrote:

I'm using the accounts-facebook to login my application and i noticed
methods are not being called when being disconnected and reconnecting to a
meteor application.

Steps to reproduce:

  1. Login using facebook account.
  2. Turn off the WIFI network (disconnects from the internet).
  3. Call a method using Meteor.call
  4. Turn on the WIFI network.

In this scenario (which is quite common) meteor tries to reconnect and
login again in the background, but the old method calls and the new method
calls are not executed.


Reply to this email directly or view it on GitHubhttps://github.com//issues/538.

@Mas-Tool

This comment has been minimized.

Mas-Tool commented Dec 10, 2012

Github: https://github.com/mastool/meteor_issue538
Steps to follow:
1.Register/Login using the default meteor account package
2.Press the button, and wait for an alert to show up with the userId.
3.Disconnect from the internet.
4.Press the button again (nothing should happen)
5.Reconnect to the internet.
6.The alert should show up (expected)

@gschmidt

This comment has been minimized.

Member

gschmidt commented Dec 12, 2012

Thanks @mastool, we will investigate.

@Mas-Tool

This comment has been minimized.

Mas-Tool commented Dec 13, 2012

I just came across another bug in the same area.
I have a few methods i call using Meteor.call('..') after the user is logged in. When the user refresh the page and the auto-login is finished, only the first Meteor.call('..') is executed and all the following ones are just dead, without even getting an error in the callback.
It's really frustrating since everything was working perfect in the previous versions and it looks like we're back to square one.

@n1mmy

This comment has been minimized.

Member

n1mmy commented Dec 18, 2012

Replicated on both master and devel. Looks like the LivedataConnection quiescence state machine is slightly borked. Continuing to investigate.

@n1mmy

This comment has been minimized.

Member

n1mmy commented Dec 19, 2012

Thanks for the clear repro case, @mastool. This should now be fixed on the devel branch (326b316). When you have a moment, could you check that this fixes the problem for you?

@n1mmy n1mmy closed this Dec 19, 2012

tyrchen pushed a commit to tyrchen/meteor that referenced this issue Dec 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment