This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
refactor to use dburles:factory #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome - thanks @dburles! |
abernix
added a commit
to abernix/meteor-guide
that referenced
this pull request
Jan 4, 2017
In the testing section of the guide (amongst others), the guide references the Meteor "Todos" app: https://github.com/meteor/todos Previously, `factory` was a locally forked Meteor package within the Todos repo which was a fork of `dburles:factory` with (minimal) tweaks. See discussion in: * meteor/todos#193 * meteor/todos#96 With the landing of meteor/todos#202, the Todos application now utilizes `dburles:factory`. This commit gives the same treatment as that PR provided to `meteor/todos` (https://github.com/meteor/todos/pull/202/files). Closes meteor#576
abernix
added a commit
to meteor/guide
that referenced
this pull request
Jan 13, 2017
In the testing section of the guide (amongst others), the guide references the Meteor "Todos" app: https://github.com/meteor/todos Previously, `factory` was a locally forked Meteor package within the Todos repo which was a fork of `dburles:factory` with (minimal) tweaks. See discussion in: * meteor/todos#193 * meteor/todos#96 With the landing of meteor/todos#202, the Todos application now utilizes `dburles:factory`. This commit gives the same treatment as that PR provided to `meteor/todos` (https://github.com/meteor/todos/pull/202/files). Closes #576
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the private factory package with
dburles:factorySee related discussion #193