-
Notifications
You must be signed in to change notification settings - Fork 98
Update testing section for Meteor 1.7 #173
Conversation
@cur33: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this! We should probably document meteor.mainModule
in the same way, but that doesn't have to be part of this PR.
content/angular/step11.md
Outdated
@@ -12,6 +12,9 @@ To do so, we'll add a [test driver](http://guide.meteor.com/testing.html#test-dr | |||
meteor add practicalmeteor:mocha | |||
``` | |||
|
|||
> ### New testing feature | |||
> While the `meteor test ...` command does still work as specified below, the release of Meteor 1.7 includes a new feature which allows you to specify the location of the test module in `package.json` with a property named `"testModule"`, which you can read more about [in the changelog](https://docs.meteor.com/changelog.html#v1720180528). In order to get the expected behavior, such that the `meteor test ...` command only uses files whose names match the format `*.test[s].*` or `*.spec[s].*`, you should either remove the line `"testModule": "tests/main.js"` from your `package.json` file, or change it to an appropriate value, before running `meteor test ...`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that "testModule"
need to appear inside a "meteor"
section of package.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a bad idea. I considered it, but the section was already pretty long, so I decided against. I could go either way on it, though.
No problem. That's a good idea to include |
@benjamn Added a clarification! Let me know if you think that makes more sense. |
This should be already fixed !! |
Guys, why has this not been merged in? I just wasted 2 hours on this issue! Ahhhgg! |
You're welcome! I'm glad this finally got added. Thanks to @abernix! |
The lack of any mention of the new 'testModule' feature in package.json after the Meteor 1.7 release threw me off as a new Meteor user going through the Angular tutorial yesterday, so I updated all three tutorials to reflect the change. Please let me know if my additions should be worded differently, or feel free to make the changes yourself.