Nexrad fixes #93
Merged
Nexrad fixes #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly detect whether we actually have all the segments. This also allows us to detect and handle receiving segments out of order. We also warn now if we have incomplete messages.
Need to force bytearray to bytes. Also manually set StreamHandler for logging.
dopplershift
force-pushed
the
nexrad-fixes
branch
from
690b0f1 to
eebf243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of glitches in the NEXRAD code. One was handling a
BitFieldthat has no values actually set; this came from a malformed file that has unfortunately gone missing. The other is data from KTLX that is missing a couple of message segments. We were getting the last one, which triggered decoding the entire message, which failed. This PR fixes that and warns when we have incomplete multi-segment messages.