refactor how collected metrics are stored to avoid parsing labels #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the prootbuf implementation takes the stringified-labels and parses them back into their original form, which is silly. refactored to avoid that, and in the process also avoid some copies and allocations. this changes public APIs around these, so should only be landed with an appropriate version bump
alex
force-pushed
the
reformat-parsing
branch
from
60c8f75 to
fb71520
Compare
tobz
approved these changes
Sep 24, 2025
tobz
added
C-exporter
|
Seems reasonable to me. 👍🏻 |
tobz
added
the
S-awaiting-release
|
great, thanks! will try to get the final (hopefully!) histogram PR up soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the prootbuf implementation takes the stringified-labels and parses them back into their original form, which is silly. refactored to avoid that, and in the process also avoid some copies and allocations.
this changes public APIs around these, so should only be landed with an appropriate version bump