Skip to content

v5.5.0

Choose a tag to compare

@michael-denyer michael-denyer released this 21 Jul 09:56
· 464 commits to master since this release
56c04e8

Changed

LMM knob validation happens when PipelineConfig is constructed, not when the runner starts. PipelineConfig re-declared the knobs LmmConfig already owned, so the rules for lmm_mode, maf, miss, l_min and l_max existed in three places and only fired part-way into a run — after kinship and eigendecomposition on some paths.

PipelineConfig now derives the LmmConfig its knobs imply: in __post_init__ to validate, and via lmm_config() where the runners need it. PipelineRunner._build_lmm_config() and validate_inputs()'s duplicate checks are gone, along with the validate_n_grid() helper v5.4.5 needed to reach across that boundary.

Upgrade note: an invalid knob now raises ValueError at PipelineConfig(...) rather than during run(), and the message carries LmmConfig's wording (l_min must be positive rather than l_min must be > 0). Code that catches on message text or relies on late validation needs a look. The CLI's own -lmin/-lmax messages are unchanged.

Full changelog: v5.4.5...v5.5.0