-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch transformations. #429
Comments
Maybe |
@Insaynoah Could you check this? If apply.altexp=TRUE
|
Line 235 in c629462
It might be that you have to move code from lines 235-258 to internal function. Then call that internal function from the transformAssay().
|
Thanks @Insaynoah if you have a chance to check it |
This is useful and often needed. @ake123 can you check? See the comments above
|
Yes. Just one reservation: imo we could allow users to choose which altexps they would like to include. The default could be all (as in apply.altexp=TRUE) but it could also be a subset selection, like apply.altexp=c("counts", "relabundance"). Could it be just a shorter "altexp" instead of "apply.altexp"? |
|
Hups, yes. |
This is ready I am waiting for the other PR closed then make a PR for this. |
Can we close this? |
We can close when the PR is merged? |
Create Function to add given transformation to all altExps / ranks at once, or at least provide an example in OMA/mia.
This is handy also since methods like
agglomerateFeaturesByRank
orsplitByRank
will only deal with count and relabundance assays, and ignore the rest (like CLR, which does translate directly in such operations). Hence there is often a need to add transformations in batch for all altExps after such operations.The text was updated successfully, but these errors were encountered: