-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metatranscriptiome workflow activities were incorrectly labelled #30
Comments
This one has to do with the names given to analysis activities. Are we able to name the workflow actions differently for metaG and metaT for clarity? The activities in question are "Metagenome assembly XXXXX_XXXXX" (should have a name like "Metatranscriptome assembly XXXXXX_XXXXX" for metaT) and "MetagenomeAnnotation activity for gold:GpXXXXXXX" (should have a name like "MetatranscriptomeAnnotation activity for gold:GpXXXXXXX" for metaT). |
I'd like to get @scanon @emileyfadrosh input on this. The issue is that while we differentiate at the omics_processing level (DNA was sequenced or RNA was sequenced), the assembly and annotation are the same analysis workflow. At one point Emiley had suggested calling the analysis simply "Annotation" because both metaT and metaG use the same analysis workflow. I'd like Emiley to indicate how things should appear in the UI and Shane to weigh in on differentiating (if necessary) in the analysis workflow metadata. |
In an email thread @emileyfadrosh indicated these should be specified/named differently in the analytic workflows. This requires a change in the schema by @wdduncan and a change to the pipeline by @scanon. Then @jbeezley needs to change the ingest. |
@scanon do you need a schema change for this? |
@scanon just to confirm, you need the class/type In the schema file it will be |
We need to differentiate metagenome analysis from metagenome analysis in two places. Currently there are nmdc:MetagenomeAnnotation and nmdc:MetagenomeAssembly To the schema we need to add nmdc:MetatranscriptomeAnnotation and nmdc:MetatranscriptomeAssembly and @scanon would need to modify how the type is set in metadata to use these two new analysis types. Change requested to the two metaT workflow metadata: microbiomedata/metaT#8 |
…y_from_WorkflowExecution Remove was_informed_by from WorkflowExecution and update data examples
The activities were labelled "metagenome" and this was corrected manually in the portal, but I believe this should be fixed upstream in the metadata to get rid of this naming hack.
The text was updated successfully, but these errors were encountered: