Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument_name_enum #984

Closed
Tracked by #1466
turbomam opened this issue Jun 12, 2023 · 5 comments
Closed
Tracked by #1466

instrument_name_enum #984

turbomam opened this issue Jun 12, 2023 · 5 comments
Assignees
Labels
closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork

Comments

@turbomam
Copy link
Member

No description provided.

@turbomam
Copy link
Member Author

added to schema, but hasn't been assigned as the range of any slot yet

have to pick between one of the two 21T FTICR (?) values

@turbomam
Copy link
Member Author

see also used

@mslarae13
Copy link
Contributor

Enum exists. need to populate permissible values for both vendor and model

Two separate enums of Insrument class

@corilo and @SamuelPurvine will work on and help with this

@mslarae13 mslarae13 assigned aclum, SamuelPurvine and corilo and unassigned turbomam Dec 15, 2023
@mslarae13
Copy link
Contributor

Class:Instrument

Has Model and Vendor enums

Need to capture the EXACT instrument
(Example: I have 3 FTICR-MS ... I need to know that this data is from FTICR.. but ALSO this data set is from FTICR-A and this is from FTICR-B)

Consider re-adding instrument_name or need a way to capture exact instrument that is minimally disruptive when new instruments are used / data is provided from new instruments ... but is not error prone... string means it's easy for people to say instrument A is instrument 1. but they're the same

@kheal
Copy link
Contributor

kheal commented May 22, 2024

This has been refactored to use the Instrument class. See microbiomedata#38.

@kheal kheal closed this as completed May 22, 2024
@kheal kheal added the closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork
Projects
None yet
Development

No branches or pull requests

6 participants