Skip to content

improve assert message #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeffra merged 1 commit into from
Apr 30, 2021
Merged

improve assert message #1024

jeffra merged 1 commit into from
Apr 30, 2021

Conversation

@stas00
Copy link
Collaborator

@stas00 stas00 commented Apr 30, 2021

I was having a hard time making sense of the assert:

AssertionError: The fp16 is not enabled but dtype on parameters not fp16

This PR tries:

fp16 is not enabled but one or several model parameters have dtype of fp16

@jeffra jeffra merged commit c4485e2 into deepspeedai:master Apr 30, 2021
@stas00 stas00 deleted the patch-2 branch April 30, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffra jeffra jeffra approved these changes

@arashashari arashashari Awaiting requested review from arashashari

@awan-10 awan-10 Awaiting requested review from awan-10

@cli99 cli99 Awaiting requested review from cli99

@conglongli conglongli Awaiting requested review from conglongli

@eltonzheng eltonzheng Awaiting requested review from eltonzheng

@minjiaz minjiaz Awaiting requested review from minjiaz

@niumanar niumanar Awaiting requested review from niumanar

@RezaYazdaniAminabadi RezaYazdaniAminabadi Awaiting requested review from RezaYazdaniAminabadi

@samyam samyam Awaiting requested review from samyam

@ShadenSmith ShadenSmith Awaiting requested review from ShadenSmith

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stas00 @jeffra