NFC: ExtractIRForPassTest.py error reporting when pass not found #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob80905
approved these changes
Mar 7, 2024
|
In between making this PR and now, another change was merged (PR #6519) to throw when the pass name was not found. I still think this PR is valuable since it provides more detailed and useful reporting than the current state. If the pass name wasn't found, seeing the list of valid passes is very useful. Additionally, if the |
pow2clk
approved these changes
May 24, 2024
|
I think this counts as a functional change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds convenient error reporting to
ExtractIRForPassTest.pywhen the specified pass is not found.No functional change.