ExtractIRForPassTest: use %dxopt on the RUN line#6519
Merged
sudonatalie merged 1 commit intomicrosoft:mainfrom May 10, 2024
Merged
ExtractIRForPassTest: use %dxopt on the RUN line#6519sudonatalie merged 1 commit intomicrosoft:mainfrom
sudonatalie merged 1 commit intomicrosoft:mainfrom
Conversation
Also, emit a better message when the desired pass does not exist (or is mis-spelled). Before this change, there would only be a confusing message about 'after' being None.
llvm-beanz
approved these changes
Apr 22, 2024
sudonatalie
approved these changes
May 10, 2024
Collaborator
|
Sorry a second review for this got lost in the shuffle, but I'll assume this should be merged now! |
This was referenced May 22, 2024
SjMxr233
pushed a commit
to ShaderHelper/DirectXShaderCompiler
that referenced
this pull request
Jul 24, 2025
Also, emit a better message when the desired pass does not exist (or is mis-spelled). Before this change, there would only be a confusing message about 'after' being None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, emit a better message when the desired pass does not exist (or is mis-spelled). Before this change, there would only be a confusing message about 'after' being None.