[python-package] use toarray() instead of todense() in tests and examples #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
chivee,
guolinke,
henry0312 and
shiyu1994
as code owners
StrikerRUS
approved these changes
Jul 6, 2021
StrikerRUS
changed the title
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the advice in #4378 (comment), this PR proposes changing a few uses of
.todense()called on sparse arrays to.toarray().This method converts a sparse array to a
np.array, a better-supported object type thannp.matrix(the type returned by.todense()).See https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.spmatrix.toarray.html.
Notes for Reviewers
There are a few other uses of
.todense()in the Dask tests, but those will be changed as part of #4378.