Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] initialize installation options with boolean values in setup.py #4620

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Contributes to #3867.

Fix the following errors:

python-package/setup.py:247: error: Argument "integrated_opencl" to "copy_files" has incompatible type "int"; expected "bool"
python-package/setup.py:247: error: Argument "use_gpu" to "copy_files" has incompatible type "int"; expected "bool"
python-package/setup.py:248: error: Argument "use_mingw" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:248: error: Argument "use_gpu" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:248: error: Argument "use_cuda" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:248: error: Argument "use_mpi" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:249: error: Argument "use_hdfs" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:252: error: Argument "nomp" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:252: error: Argument "bit32" to "compile_cpp" has incompatible type "int"; expected "bool"
python-package/setup.py:252: error: Argument "integrated_opencl" to "compile_cpp" has incompatible type "int"; expected "bool"

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I can see in the lint logs that these warnings have been resolved.

@jameslamb jameslamb merged commit 6a3f2a9 into master Sep 21, 2021
@jameslamb jameslamb deleted the mypy branch September 21, 2021 03:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants