-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [python-package] move tool configuration to pyproject.toml #5872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
StrikerRUS,
shiyu1994,
jmoralez and
guolinke
as code owners
May 7, 2023 05:45
UriyaHarpeness
approved these changes
May 7, 2023
jameslamb
changed the title
[ci] [python-package] moving tool configuration to pyproject.toml
[ci] [python-package] move tool configuration to pyproject.toml
May 7, 2023
jmoralez
reviewed
May 8, 2023
jmoralez
approved these changes
May 8, 2023
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3867.
Contributes to #4308.
Contributes to #5061.
Proposes moving configuration for all Python linting tools that support it into
pyproject.toml
(and forflake8
, which doesn't support it per PyCQA/flake8#234, intosetup.cfg
).Also adds configuration to skip running linters over the
lightgbm-python/
directory (new local build directory introduced in #5837), to help with local development.Notes for Reviewers
Many Python tools have been moving in this direction, ever since PEP 518 was accepted back in 2016.
From the PEP (link) ...
And projects using those tools have followed. For example, dmlc/xgboost#9112.
Benefits of this Change
Sets up
pyproject.toml
andsetup.cfg
as sources of configuration for the Python project, reducing the size of the diff to be reviewed in #5759.Puts tool configuration into a format used by many other Python projects, making it a bit easier (I hope) for new contributors to work on LightGBM.