-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.0.0 #5952
Release v4.0.0 #5952
Conversation
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
I would like to get #5948 in if possible, to make the changes in this version clearer in the docs. But otherwise, I think this is ready! @guolinke @shiyu1994 @jmoralez could you please look at this and #5153, and:
If we can get v4.0.0 out in the next week, I'll announce it at SciPy 2023 (link) next week if I'm able to get a lightning talk slot there 😊 |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks! @shiyu1994 what do you think? Can I move forward with releasing v4.0.0? Also note that CRAN will not be accepting submissions from July 21-August 7... I hope we can get this submitted before then. per https://cran.r-project.org/
|
I'm OK with that. Let's release a 4.0.0 version first. I still have several on going PRs. But let's left them in subsequent releases (hopefully very soon). |
Ok great, thank you so much! Yeah nothing prevents us from doing a 4.0.1 or 4.1.0 shortly after this... I would actually love to see the project get into the habit of more frequent, smaller releases 😊 I will work on the remaining release tasks over the next few days. |
Merged in |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
Most recent build (20 minutes ago) passed on this branch: https://readthedocs.org/projects/lightgbm/builds/21280161/ And the docs look to me: |
I'm traveling right now and don't have access to my M2 Mac laptop, but I just submitted the R package to the mac-builder testing service. The results will show up here: https://mac.r-project.org/macbuilder/results/1689263124-d89c2bc709b122ea/ If that passes, I'll merge this PR and officially create the v4.0.0 release 😁 |
Wow that was VERY fast... running
I'll begin with the release shortly. |
I just published the v4.0.0 release on GitHub: https://github.com/microsoft/LightGBM/releases/tag/v4.0.0 That triggered this Azure DevOps build to build all the artifacts: https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=14917&view=results Once that's done, I'll publish wheels to PyPI and submit the R package to CRAN. |
Made changes at https://readthedocs.org/projects/lightgbm/versions/.
Done.
Done. successful build: https://readthedocs.org/projects/lightgbm/builds/21293502/ |
All artifacts have been built successfully, and attached to the release: https://github.com/microsoft/LightGBM/releases |
Updated git fetch upstream --tags
git tag -d stable
git push upstream :refs/tags/stable
git tag stable v4.0.0
git push upstream stable https://github.com/microsoft/LightGBM/tags |
The CRAN release is currently blocked. Getting the following error when trying to upload it.
https://twitter.com/henrikbengtsson/status/1679036506382430209 From https://cran.r-project.org/
🙃 I'll check back later tonight, and keep checking until CRAN is available again. |
Uploaded v4.0.0 wheels and sdist to PyPI 😁 https://pypi.org/project/lightgbm/4.0.0/ https://pypi.org/project/lightgbm/4.0.0/#files |
CRAN is accepting submissions again 🎉 I just submitted the R package there. @shiyu1994 please check your email, they will send you a link to click on to confirm the submission. |
Homebrew recipe was updated in Homebrew/homebrew-core#136562. |
@shiyu1994 please check your email for a message from CRAN. Sorry to |
For those subscribed here waiting for v4.0.0 of the R package to make it to CRAN... our 2 attempted submissions this week were not accepted. CRAN is on its summer break starting today (see notice at https://cran.r-project.org/) and ending August 7. We will try to resolve the issues (#5987) and submit to CRAN again when they return. If you'd like to test out v4.0.0 of the package prior to that, you can follow the instructions at https://github.com/microsoft/LightGBM/tree/master/R-package#installation or install from the source distribution hosted here on GitHub. install.packages("https://github.com/microsoft/LightGBM/releases/download/v4.0.0/lightgbm-4.0.0-r-cran.tar.gz") Sorry for the inconvenience, we're doing the best we can 😅 |
✅ uploaded |
Any idea on when 4.0 will make it to CRAN? Thanks for the amazing work! |
As it says a few comments up (#5952 (comment)), you can subscribe to #5987 to track the progress. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixes #4788.
Fixes #5153.
Release checklist:
Copied from #5666, with a few new additions.
before merge
configure
file of R-package:/gha run r-configure
.development.mode
fromunreleased
torelease
in pkgdown config file.versionadded::
annotations (docs on those)/gha run r-valgrind
(docs link)PRs:
after merge
v*
tag to triggerGitHubRelease
action at Azure Pipelines.Draft
to normal one.stable
tag at GitHub.What about the changelog?
As described in #4930 (comment), previous patch releases that didn't release latest
master
interfere with the automatic release notes generation tool used in this repo.In each of those special releases, we copied in the list of PRs into the notes. I've listed all of those below. When I create the actual GitHub release, I'll combine all of them.
changelog from v3.3.1 to when v3.3.2 was created (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.2 was created to date of v3.3.3 (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.3 was created to v3.3.4 (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.4 was created to v3.3.5 (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.
changelog from when v3.3.5 was created to today (click me)
NOTE: I wrapped this in a markdown text block so GitHub stops re-evaluating the links.