-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] further simplify CI configurations #6463
Conversation
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: failure ❌. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Oliver Borchert <oliver.borchert@quantco.com>
I pushed a
Just pushed a commit fixing that: f99a01e It's so minor and noncontroversial, I'm going to merge this if CI passes, without waiting for another review. We can revert it easily if anyone comes back and disagrees with the changes I made. |
Follow-up to #6458
Proposes the following simplifications to CI configurations and scripts:
CONDA_ENV
environment variable and just hard-codes it in scriptsrelease/*
master
, to avoid releasing the breaking changes building up there in anticipation of 4.0... but that's not the state this project is in any moreconda
-setup code intest.sh
.ci/get_workflow_status.py
docker run --env
Also increases the valgrind allow-possibly-lost-bytes limit (see #6213 (comment))