Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] further simplify CI configurations #6463

Merged
merged 10 commits into from
May 28, 2024
Merged

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented May 23, 2024

Follow-up to #6458

Proposes the following simplifications to CI configurations and scripts:

  • removes CONDA_ENV environment variable and just hard-codes it in scripts
  • removes configurations to run CI on PRs targeting any branch matching the pattern release/*
    • this was added back when we were releasing from branches not targeting master, to avoid releasing the breaking changes building up there in anticipation of 4.0... but that's not the state this project is in any more
  • consolidates conda-setup code in test.sh
  • reduces duplication of image URI in CUDA CI job config
  • removes a Python 2.7 try-catch import in .ci/get_workflow_status.py
  • stops writing an env file in QEMU_multiarch job, in favor of just using docker run --env

Also increases the valgrind allow-possibly-lost-bytes limit (see #6213 (comment))

@jameslamb
Copy link
Collaborator Author

jameslamb commented May 23, 2024

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/9201526295

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

jameslamb commented May 27, 2024

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/9249940386

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

jameslamb commented May 27, 2024

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/9259654005

Status: success ✔️.

@jameslamb jameslamb changed the title WIP: [ci] further simplify CI configurations [ci] further simplify CI configurations May 28, 2024
@jameslamb jameslamb marked this pull request as ready for review May 28, 2024 03:55
Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/cuda.yml Outdated Show resolved Hide resolved
.github/workflows/cuda.yml Outdated Show resolved Hide resolved
jameslamb and others added 3 commits May 28, 2024 08:33
Co-authored-by: Oliver Borchert <oliver.borchert@quantco.com>
@jameslamb
Copy link
Collaborator Author

I pushed a pydistcheck release last night that broke CI here.

ERROR: found the following unrecognized checks passed via '--ignore': compiled-objects-have-debug-symbols,distro-too-large-compressed

(build link)

Just pushed a commit fixing that: f99a01e

It's so minor and noncontroversial, I'm going to merge this if CI passes, without waiting for another review. We can revert it easily if anyone comes back and disagrees with the changes I made.

@jameslamb jameslamb merged commit ceb9986 into master May 28, 2024
39 checks passed
@jameslamb jameslamb deleted the ci/more-simplification branch May 28, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants