Bugfix: Fix crashing in postgres-backed storage #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at's OK for MLOS) to make sure PG won't fail the update of `trial` if there is a duplicate record in `trial_status`
motus
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a PostgreSQL transaction failure issue where inserting duplicate records in the trial_status table would cause the entire transaction to fail, preventing updates to the trial table. The fix splits the database operations into separate transactions to ensure independence.
- Separates
trial_statusandtrialtable updates into independent transactions - Prevents PostgreSQL transaction rollback when duplicate keys are encountered in
trial_status
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
In PostgreSQL, attempting to insert a record with conflicting keys fails (a benign action in MLOS), fails the entire transaction thus preventing the update of other tables. Splitting the update into two independent transactions solves the problem.
Description
Update tables
trial_statusandtrialin separate transactions (that's OK for MLOS) to make sure PG won't fail the update oftrialif there is a duplicate record intrial_status.Type of Change
Testing
Run TQP benchmark with PostgreSQL storage.