Skip to content

Bugfix: Fix crashing in postgres-backed storage #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix: Fix crashing in postgres-backed storage #1000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e86980
update tables `trial_status` and `trial` in separate transactions (th…
motus Sep 22, 2025
06a8d2c
Update mlos_bench/mlos_bench/storage/sql/trial.py
motus Sep 22, 2025
8e09bc8
fix the copilot-generated comment
motus Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlos_bench/mlos_bench/storage/sql/trial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ def update(
metrics = super().update(status, timestamp, metrics)
with self._engine.begin() as conn:
self._update_status(conn, status, timestamp)
# Use a separate transaction to avoid issues with PostgreSQL's duplicate key
# constraint handling. (See Issue #999).
with self._engine.begin() as conn:
try:
if status.is_completed():
# Final update of the status and ts_end:
Expand Down
Loading