-
Notifications
You must be signed in to change notification settings - Fork 264
Regular master -> vNext merge #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix WriteValue for DateTimeOffset to write as string (i.e. with quotes)
Adding OData processor to readme.
…YAML doesn't vary by culture. For example, the parser should always treat 100.000 as one hundred, not one hundred thousand, even if the operating system on the machine is set to use French.
Parse decimals and ints with InvariantCulture since JSON/YAML doesn't vary by culture.
… in the DOM. - Add validation rule to validate the required fields in Parameter.
Add a few more tests
…orParameterLocation Ensure parsing null in "in" in Parameter does not fail
These have been reviewed before. Just a regular merge from master -> vNext |
Looks like there's still a bug with the Culture Info decimal. I'll take a look |
I'll wait until #335 is checked-in. |
Add CultureInfo.InvariantCulture in the TryParse's in CreateAny.
Shwetap05
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…neOne Update Package Version to 1.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.