Skip to content

Conversation

@SteAmeR
Copy link
Contributor

@SteAmeR SteAmeR commented Jan 18, 2023

It was derived IsoExtractor with some minor UDF context changes

It was derived IsoExtractor with some minor UDF context changes
@gfs
Copy link
Contributor

gfs commented Jan 18, 2023

@SteAmeR Thank you for the contribution. For me to accept it you have to agree to the CLA. Once you do so I can add the plumbing to have this used when iso parsing fails.

@SteAmeR
Copy link
Contributor Author

SteAmeR commented Jan 18, 2023

@microsoft-github-policy-service agree [company="default"]

@SteAmeR
Copy link
Contributor Author

SteAmeR commented Jan 18, 2023

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@gfs
Copy link
Contributor

gfs commented Jan 18, 2023

Thanks, and thanks for your contribution to the project!

In the future, please open a single PR (with multiple commits if needed) for each logical topic, rather than PRs for each individual commit. I'll cherrypick the other PRs into this one and review.

Add UDF extractror
Add DiscUtils.Udf dependency
Add enumerate to UDF
Add enum, and signature check
@SteAmeR
Copy link
Contributor Author

SteAmeR commented Jan 18, 2023

Thanks, and thanks for your contribution to the project!

In the future, please open a single PR (with multiple commits if needed) for each logical topic, rather than PRs for each individual commit. I'll cherrypick the other PRs into this one and review.

Sorry for PR mess :\

@gfs
Copy link
Contributor

gfs commented Jan 18, 2023

Thanks, and thanks for your contribution to the project!
In the future, please open a single PR (with multiple commits if needed) for each logical topic, rather than PRs for each individual commit. I'll cherrypick the other PRs into this one and review.

Sorry for PR mess :\ I'm still newbee on github :(

No problem. It can take a bit to get accustomed to.

I'm working on trying to get a sample file that works with the DiscUtils UDF extractor. So far I've tried genudfimage which produced something parseable by the existing iso parser and with iso headings, and mkudffs, which produces a UDF image that is moutnable, but is not parsed properly by DiscUtils. Will need a safe to distribute sample file to validate behavior before merging. Do you have a suggestion for a tool to generate a udf image?

@SteAmeR
Copy link
Contributor Author

SteAmeR commented Jan 18, 2023

Sure :) https://www.poweriso.com/download.htm

Please follow steps after the installation;

1 - > Options - >Configuration -> File Systems -> Select only UDF deselect other default file system

2 -> File -> New -> UDF DVD

3 -> Add some file/files to project and save

4 - > Tools -> Convert File Format

And final step -> Change iso extension manually to udf as below image and ok

udf

Regards

@gfs
Copy link
Contributor

gfs commented Jan 19, 2023

Thanks. I'll give this a shot today.

@SteAmeR
Copy link
Contributor Author

SteAmeR commented Jan 19, 2023

Thanks. I'll give this a shot today.

I hope it helps. Also, #120 PR has a build error. How soon will it be released? I need to do my project, as well 😊

Regards,

@gfs
Copy link
Contributor

gfs commented Jan 20, 2023

@SteAmeR Thanks for the reference. I was able to create a disc image that is parseable with the UDF Extractor implementation and the pipelines tests should be running now.

/azp run

@gfs
Copy link
Contributor

gfs commented Jan 20, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gfs
Copy link
Contributor

gfs commented Jan 20, 2023

Thanks for your contribution! Appears to be working on my end now.

For timing, I plan to merge this once the CI checks pass, after merging the new build should be available on nuget about an hour later.

@gfs gfs merged commit 35548c9 into microsoft:main Jan 20, 2023
@gfs gfs changed the title Create UDF Exctractor Create UDF Extractor Jan 20, 2023
@SteAmeR
Copy link
Contributor Author

SteAmeR commented Jan 20, 2023

Great works. Thanks for your cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants