remove whitespace in nav bar completions #11829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Oct 25, 2016
| // We ma get a string with newlines or other whitespace in the case of an object dereference | ||
| // (eg: "app\n.onactivated"), so we should remove the whitespace for readabiltiy in the | ||
| // navigation bar. | ||
| return getFunctionOrClassName(<ArrowFunction | FunctionExpression | ClassExpression>node).replace(whiteSpaceRegex, ""); |
There was a problem hiding this comment.
I would move this in getFunctionOrClassName instead.
vladima
reviewed
Oct 25, 2016
| * | ||
| * does not match. | ||
| */ | ||
| const whiteSpaceRegex = /(\s|\t|\n|\r)+/g; |
There was a problem hiding this comment.
I don't think you need to list other options except \s.
per this
\s
Matches a single white space character, including space, tab, form feed, line feed and other Unicode spaces. Equivalent to [ \f\n\r\t\v\u00a0\u1680\u180e\u2000-\u200a\u2028\u2029\u202f\u205f\u3000\ufeff].
mhegazy
approved these changes
Oct 25, 2016
billti
reviewed
Oct 30, 2016
| //// .a = function() { }; | ||
| //// })(); | ||
|
|
||
| function navExact(name: string, kind: string) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where nav bar items in Visual Studio wouldn't remove whitespace (esp. newlines), making the nav bar add rows to accomodate the entries and waste screen real-estate.