Adds tracking for failed tests, re-running failed tests. #16701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gotta take a look but this is great :) 🍰 |
yuit
reviewed
Jun 26, 2017
| @@ -57,9 +58,12 @@ const cmdLineOptions = minimist(process.argv.slice(2), { | |||
| inspect: process.env.inspect || process.env["inspect-brk"] || process.env.i, | |||
| host: process.env.TYPESCRIPT_HOST || process.env.host || "node", | |||
| browser: process.env.browser || process.env.b || "IE", | |||
| bail: process.env.bail || false, | |||
There was a problem hiding this comment.
Exit on the first failed test. This already exists in jakefile.js
scripts/mocha-file-reporter.js
Outdated
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
nit: either we remove this or we add it everywhere with comments
scripts/mocha-file-reporter.js
Outdated
| * @param keepFailed {Boolean} | ||
| * @param fn {Function} | ||
| */ | ||
| FileReporter.writeFailures = function (file, failures, keepFailed, fn) { |
There was a problem hiding this comment.
Could you rename file to fileName or filePath
There was a problem hiding this comment.
I only added it here for better intellisense.
rbuckton
force-pushed
the
failedTestTracking
branch
from
c341c4b to
ede814b
Compare
sandersn
reviewed
Jun 28, 2017
scripts/mocha-file-reporter.js
Outdated
| var reporterOptions = this.reporterOptions = options.reporterOptions || {}; | ||
| reporterOptions.file = reporterOptions.file || ".failed-tests"; | ||
| reporterOptions.keepFailed = reporterOptions.keepFailed || false; | ||
| reporterOptions.reporter = reporterOptions.reporter; |
There was a problem hiding this comment.
this looks like a rigid idiom, but it still bugs me. Can you remove it?
sandersn
approved these changes
Jun 28, 2017
|
@rbuckton can you refresh this PR? |
RyanCavanaugh
requested changes
Mar 15, 2018
|
Superseded by #25004. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following capabilities:
runtestsorruntests-parallel), any failing tests will be written to a .failed-tests file.--optsoption.--grepoption.jake runtests failed=trueorgulp runtests --failedwill run only the failing tests from the last test run.failedoption will be superseded by thetestsoption, if both are provided.failedoption is not currently supported on theruntests-paralleltask.keepFailed=trueto jake or--keepFailedto gulp.Examples (jake)
Examples (gulp)