Adds failed test tracking #25004
Merged
Adds failed test tracking #25004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
force-pushed
the
trackFailedTests
branch
from
dc11404 to
5c8f1a0
Compare
rbuckton
force-pushed
the
trackFailedTests
branch
from
5c8f1a0 to
0944c29
Compare
|
ping @weswigham, @mhegazy |
weswigham
reviewed
Jun 25, 2018
Gulpfile.js
Outdated
| @@ -298,7 +298,8 @@ gulp.task(runJs, /*help*/ false, [typescriptServicesJs, tsserverlibraryDts], () | |||
|
|
|||
| gulp.task( | |||
| "tests", | |||
| "Builds the test infrastructure using the built compiler", | |||
| if (tests || runners || light || testTimeout || taskConfigsFolder) { | |||
There was a problem hiding this comment.
Is there a syntax error here?
rbuckton
force-pushed
the
trackFailedTests
branch
from
eee7c20 to
dd66cbb
Compare
rbuckton
force-pushed
the
trackFailedTests
branch
from
dd66cbb to
d3ef20c
Compare
weswigham
reviewed
Jun 25, 2018
| args.push(arg); | ||
| }); | ||
|
|
||
| let mocha = "./node_modules/mocha/bin/mocha"; |
There was a problem hiding this comment.
I think we should resolve this path using __dirname to handle if Jake or gulp is involved in a project subfolder.
There was a problem hiding this comment.
Both jake and gulp reset cwd to the location of the jakefile/gulpfile.
weswigham
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to track failing tests when building with the "runtests" or "runtests-parallel" build tasks. The names of failing tests are written to a .failed-tests file in the workspace root. You can re-run failing tests using
jake runtests failed=true(orgulp runttests --failed, once gulp is working again).Whenever a failing test passes, it is removed from the .failed-tests file. If all tests pass, the .failed-tests file is removed. This helps when running down a large number of failing tests, without having to continually rerun the entire test suite.