Improved errors for 'catch'/'finally' blocks missing 'try' statements #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry' block. Fixes #216. As a note of this fix, when a 'catch' block is followed by a 'finally' block, only the 'catch' keyword gets an error reported on it.
DanielRosenwasser
changed the title
catches finally parse nicely
DanielRosenwasser
changed the title
catches finally parse nicely
| @@ -160,6 +160,8 @@ module ts { | |||
| Constructor_implementation_expected: { code: 2240, category: DiagnosticCategory.Error, key: "Constructor implementation expected." }, | |||
| An_export_assignment_cannot_be_used_in_a_module_with_other_exported_elements: { code: 2245, category: DiagnosticCategory.Error, key: "An export assignment cannot be used in a module with other exported elements." }, | |||
| A_parameter_property_is_only_allowed_in_a_constructor_implementation: { code: 2246, category: DiagnosticCategory.Error, key: "A parameter property is only allowed in a constructor implementation." }, | |||
| A_catch_clause_must_be_preceded_by_a_try_statement: { code: 2249, category: DiagnosticCategory.Error, key: "A 'catch' clause must be preceded by a 'try' statement." }, | |||
There was a problem hiding this comment.
these seem unnecessary. you can just call parseTryStatement and you'll get the perfectly good error "'try' expected"
Conflicts: src/compiler/diagnosticMessages.json
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Aug 4, 2014
Improved errors for 'catch'/'finally' blocks missing 'try' statements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try-lesscatchBlocksIf the parser now sees
or
the user will be issued the message
try-lessfinallyBlocksIf the parser now sees
the user will be issued the message
Fixes #216.