Skip to content

Replace subtype check in derivedness check with flags and structure checks #27403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2018
Merged

Replace subtype check in derivedness check with flags and structure checks #27403

merged 3 commits into from
Oct 4, 2018

Conversation

weswigham
Copy link
Member

This way even if a given class or object overrides a method on Object or Function in a structurally incompatible way, they still get measured as instances of those bases for instanceof.

Fixes #26159

@sandersn sandersn mentioned this pull request Oct 4, 2018
Merged
@weswigham weswigham merged commit f074049 into microsoft:master Oct 4, 2018
@weswigham weswigham deleted the instanceof-extending-function branch October 4, 2018 19:55
@sandersn sandersn mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @RyanCavanaugh