🤖 User test baselines have changed #27571
Conversation
| Standard output: | ||
| node_modules/@types/react-native/index.d.ts(3895,26): error TS2693: 'setImmediate' only refers to a type, but is being used as a value here. | ||
| node_modules/@types/react-native/index.d.ts(3896,28): error TS2693: 'clearImmediate' only refers to a type, but is being used as a value here. | ||
| Version 3.2.0-dev |
There was a problem hiding this comment.
The two typescript-starter diffs are probably caused by the sub module update. Not sure why this one acts like the tsconfig is gone now.
|
|
||
|
|
||
|
|
||
| Standard error: | ||
|
|
||
| ../../../src/compiler/checker.ts:14283 | ||
| return !!(resolved.callSignatures.length || resolved.constructSignatures.length || |
There was a problem hiding this comment.
Looks like getJSClassType returns a type without callSignatures initialized correctly. Need to confirm.
There was a problem hiding this comment.
Actually, this is a result of #27403.
@weswigham can you take a look?
| @@ -1,21 +1,25 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| lib/adapters/http.js(12,19): error TS2732: Cannot find module './../../package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension | |||
| lib/adapters/http.js(83,22): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'. | |||
| lib/adapters/http.js(44,28): error TS2345: Argument of type 'Uint8Array' is not assignable to parameter of type 'string'. | |||
There was a problem hiding this comment.
Probably all these changes are from updating axios.
| @@ -1,72 +1,66 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| lib/Browser.js(71,49): error TS2322: Type 'Promise<CDPSession>' is not assignable to type 'Promise<Puppeteer.CDPSession>'. | |||
There was a problem hiding this comment.
Seems like the results of the submodule update too, but I need to look at the diff using beyond compare (github missed all the nearly-identical lines)
| packages/react-dev-utils/webpackHotDevClient.js(233,15): error TS2339: Property 'hot' does not exist on type 'NodeModule'. | ||
| packages/react-dev-utils/webpackHotDevClient.js(261,23): error TS2339: Property 'hot' does not exist on type 'NodeModule'. | ||
| packages/react-dev-utils/workspaceUtils.js(11,25): error TS2307: Cannot find module 'find-pkg'. | ||
| fixtures/output/webpack-message-formatting/src/AppBabel.js(6,8): error TS17008: JSX element 'div' has no corresponding closing tag. |
There was a problem hiding this comment.
These errors are not quite like the others. Parse errors from an update, maybe?
typescript-bot
force-pushed
the
user-update-20180905
branch
from
1338894 to
69bf03d
Compare
|
I think these are now fixed or accepted. |
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh